use newest world callback on_done #21027
Conversation
|
Is there any way this could be tested? |
There was a problem hiding this comment.
This has the sames issue as #19924 (comment) and since it obviously lasted longer than a month it should be probably quoted similar to the ones in REPL.jl .
Also, when is the REPL mode loaded? It seems that it's better to run a heigher level function in the latest world instead.
|
So what changes should be made? The REPL modes are all initialized at run_interface. |
|
@yuyichao, is this want you meant? |
base/LineEdit.jl
Outdated
| Expr(:body, | ||
| Expr(:return, | ||
| Expr(:call, | ||
| mode(state(s, s.current_mode)).on_done, |
There was a problem hiding this comment.
Actually the callee also needs to be quoted...
There was a problem hiding this comment.
check the latest commit.
|
It seems that appveyor failure is irrelevant. |
|
I see. Is it good to go? |
|
I approved this 2 days ago afaict.... |
was never answered |
RCall REPL mode requires a custom
on_doneto work. At the current master branch, it is broken.It occurs after #17057 and has been reported by #19774. @KristofferC has reported a similar bug for custom keybind in REPL mode at #19718 and it was patched at #19924. This solution suggested is to use
evalto execute the callbacks, it serves as a temp solution before a better solution arrives.