-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL keybindings cannot be changed after #265 fix #19718
Labels
bug
Indicates an unexpected problem or unintended behavior
regression
Regression in behavior compared to a previous version
REPL
Julia's REPL (Read Eval Print Loop)
Milestone
Comments
KristofferC
added
docs
This change adds or pertains to documentation
REPL
Julia's REPL (Read Eval Print Loop)
labels
Dec 25, 2016
KristofferC
changed the title
Docs for changing REPL keywords in manual now faulty.
Docs for changing REPL keybindings are incorrect.
Dec 25, 2016
Can I work on this? |
This is not a doc issue. |
Why not? It's the docs that are incorrect here. |
Because it's a REPL bug. |
KristofferC
changed the title
Docs for changing REPL keybindings are incorrect.
REPL keybindings cannot be changed after #265 fix
Dec 27, 2016
tkelman
added
the
regression
Regression in behavior compared to a previous version
label
Dec 29, 2016
https://discourse.julialang.org/t/proposal-for-a-first-class-dispatch-wrapper/1127 would help make this not-an-issue. |
An ugly workaround? diff --git a/base/LineEdit.jl b/base/LineEdit.jl
index 2749222..dfc237e 100644
--- a/base/LineEdit.jl
+++ b/base/LineEdit.jl
@@ -734,7 +734,7 @@ end
keymap_fcn(f::Void, c) = (s, p) -> return :ok
function keymap_fcn(f::Function, c)
return function (s, p)
- r = f(s, p, c)
+ r = eval(Expr(:call,f,s, p, c))
if isa(r, Symbol)
return r
else
|
Fixed by #19924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Indicates an unexpected problem or unintended behavior
regression
Regression in behavior compared to a previous version
REPL
Julia's REPL (Read Eval Print Loop)
Running the example at: http://docs.julialang.org/en/latest/manual/interacting-with-julia.html#Customizing-keybindings-1 now gives:
It should probably be updated to show how to do it in a post #265 world. cc @vtjnash
(This is after applying #19697)
The text was updated successfully, but these errors were encountered: