Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix REPL callbacks to use eval so newest world function is executed #19924

Merged
merged 1 commit into from
Jan 11, 2017
Merged

fix REPL callbacks to use eval so newest world function is executed #19924

merged 1 commit into from
Jan 11, 2017

Conversation

KristofferC
Copy link
Member

Implements the suggestions by @luchr to get the REPL callbacks work again. (This also makes the syntax highlighting in OhMyREPL work again.)

@stevengj
Copy link
Member

stevengj commented Jan 7, 2017 •
edited
Loading

When you have something that is explicitly of type ::Function, e.g. because it is a ::Function field of a type, it would be nice if it defaulted to using the newest world. The current default is almost never what you want.

@vtjnash
Copy link
Member

vtjnash commented Jan 7, 2017

Yes, that'll be fixed before we make the v0.6 release.

@KristofferC
Copy link
Member Author

Is this ok for now until that is fixed @vtjnash?

@kshyatt kshyatt added the REPL Julia's REPL (Read Eval Print Loop) label Jan 8, 2017
@jverzani jverzani mentioned this pull request Jan 9, 2017
Closed
@KristofferC
Copy link
Member Author

Bump.

@StefanKarpinski
Copy link
Member

@vtjnash: unless this is really bad for some reason, let's merge this bandaid until a better fix exists.

@vtjnash
Copy link
Member

vtjnash commented Jan 11, 2017

yeah, it's fine. If it was going in longer term, I would make sure this was more robust (with the necessary QuoteNode), but I don't expect to see it lasting more than a month.

@stevengj stevengj merged commit faaabac into master Jan 11, 2017
@stevengj stevengj deleted the kc/repl_worlds branch January 11, 2017 12:33
@KristofferC KristofferC mentioned this pull request Jan 17, 2017
Closed
@tkelman tkelman mentioned this pull request Feb 2, 2017
Closed
@randy3k
Copy link
Contributor

randy3k commented Mar 14, 2017

This merge only allows custom keybinds but not a custom on_done which is required to fix JuliaInterop/RCall.jl#171

@randy3k
Copy link
Contributor

randy3k commented Mar 14, 2017 •
edited
Loading

Am I correct that this line needs a eval too?

@randy3k randy3k mentioned this pull request Mar 14, 2017
Merged
@rfourquet rfourquet mentioned this pull request Jul 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KristofferC @stevengj @vtjnash @StefanKarpinski @randy3k @kshyatt @luchr