Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload Base.showerror instead of Base.show for PkgError. #1080

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Overload Base.showerror instead of Base.show for PkgError. #1080

merged 1 commit into from
Feb 20, 2019

Conversation

fredrikekre
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Feb 20, 2019
@bors @GregPlowman @fredrikekre
Merge #1068 #1080
052ebca 
1068: Update doc strings for pin, free r=fredrikekre a=GregPlowman

A few changes to help strings for `pin`, `free`.

Correct case for `PackageSpec`
Add examples for `pin`


1080: Overload Base.showerror instead of Base.show for PkgError. r=fredrikekre a=fredrikekre



Co-authored-by: GregPlowman <gregplowman@users.noreply.github.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 20, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Feb 20, 2019
@bors @fredrikekre
Merge #1080
40c849e 
1080: Overload Base.showerror instead of Base.show for PkgError. r=fredrikekre a=fredrikekre



Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 20, 2019

Build failed

@fredrikekre
Copy link
Member Author

fredrikekre commented Feb 20, 2019 •
edited
Loading

Ok, JuliaLang/julia#29466 ....

PkgError printing: Test Failed at /home/travis/build/JuliaLang/Pkg.jl/test/pkg.jl:688
  Expression: sprint(show, err) == "PkgError(\"foobar\")"
   Evaluated: "Pkg.Types.PkgError(\"foobar\")" == "PkgError(\"foobar\")"

@fredrikekre
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 20, 2019
@bors @fredrikekre
Merge #1080
f3c1ce1 
1080: Overload Base.showerror instead of Base.show for PkgError. r=fredrikekre a=fredrikekre



Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 20, 2019

Build succeeded

@bors bors bot merged commit cae8b4f into master Feb 20, 2019
@bors bors bot deleted the fe/show branch February 20, 2019 14:55
@IanButterworth IanButterworth mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
display and printing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fredrikekre