Update doc strings for pin, free #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall, looks good to me. Particularly useful are the examples for pin 👍 |
fredrikekre
reviewed
Feb 19, 2019
fredrikekre
force-pushed
the
glp/doc_pin_free
branch
from
1901784
to
520c430
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2019
1068: Update doc strings for pin, free r=fredrikekre a=GregPlowman A few changes to help strings for `pin`, `free`. Correct case for `PackageSpec` Add examples for `pin` 1080: Overload Base.showerror instead of Base.show for PkgError. r=fredrikekre a=fredrikekre Co-authored-by: GregPlowman <gregplowman@users.noreply.github.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Build failed (retrying...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to help strings for
pin,free.Correct case for
PackageSpecAdd examples for
pin