-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precompile: pipe error messages during autoprecompilation to Main.err for easier inspection #3536
precompile: pipe error messages during autoprecompilation to Main.err for easier inspection #3536
Conversation
I have the following thoughts:
|
It could be pushed to |
But in no interactive mode it should just show |
cc09eae
to
9b31814
Compare
Updated to use |
test/pkg.jl
Outdated
@@ -692,7 +692,7 @@ end | |||
|
|||
@testset "PkgError printing" begin | |||
err = PkgError("foobar") | |||
@test occursin("PkgError(\"foobar\")", sprint(show, err)) | |||
@test occursin("PkgError: foobar", sprint(show, err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredrikekre is there a reason why chaning this show method is bad, given #1080 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to make a new error type with a show method, given I guess there was a reason why this was tested for
c55ffa2
to
1b9f3d3
Compare
fedad2a
to
c211673
Compare
I'm going to merge and get this onto julia master so we can try it out before 1.10 |
@KristofferC Maybe marking this for backport is too much? What do you think? |
It seems the way auto-precompilation only summarizes which packages errored not the verbose error details is unpopular so this
makes autoprecompilation show errors the way an explicitPkg.precompile
does.Updated: Now autoprecompilation pipes any errors to
Main.err
Also in noninteractive & CI modes it will always show errors now.
Closes #3444
Closes #3428