Homography Validation Update #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtially implemented
| virtual std::vector<std::size_t> getSampleCorrespondenceIndices() const final override | ||
| { | ||
| // Make sure there are at least two times as many points as the number of sample points | ||
| if ((rows * cols / 2) < 8) |
There was a problem hiding this comment.
Do we still want to have a variable number of points used, or are we comfortable fixing it to 8?
There was a problem hiding this comment.
I just pushed a change to use the minimum number of points (4, instead of 8). This struct is easy enough to override, so I don't think we necessarily need to make it a parameterizable number of points
colin-lewis-19
approved these changes
Jul 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises #56. @colin-lewis-19 can you review?