Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified circle grid finder update #110

Conversation

marip8
Copy link
Collaborator

@marip8 marip8 commented Nov 13, 2023

Changes from @marrts 09f605f and 5fbd140 to improve the performance of the modified circle grid target finder

@marip8 marip8 force-pushed the update/modified-circle-grid-target-finder branch from eb659b0 to ea20878 Compare November 13, 2023 23:25
@marip8
Copy link
Collaborator Author

marip8 commented Nov 14, 2023

@marrts aren't most of these == comparisons between doubles? If so, we should probably change them to the isEqual function instead

@marrts
Copy link
Contributor

marrts commented Nov 14, 2023

@marrts aren't most of these == comparisons between doubles? If so, we should probably change them to the isEqual function instead

They are double comparisons, but it is iterating through a vector and comparing to values that were previously extracted from that same vector, so it's maybe not the optimal approach for what it's trying to do, but the == comparison should always evaluate to true when it finds the right value

@marip8
Copy link
Collaborator Author

marip8 commented Nov 14, 2023

Does this conflict with #104? It seems like some of these changes undo those added in that PR

@marip8
Copy link
Collaborator Author

marip8 commented Nov 14, 2023

Closing; turns out, the reference commits were added and modified in #104, which has the correct changes

@marip8 marip8 closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants