Improve finding the origin of a modified circle grid #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marip8 You have any issues with this change? |
marip8
requested changes
May 12, 2022
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
marip8
reviewed
May 12, 2022
marip8
requested changes
May 13, 2022
rct_image_tools/src/rct_image_tools/modified_circle_grid_finder.cpp
Outdated
Show resolved
Hide resolved
marip8
approved these changes
May 13, 2022
marip8
added a commit
to marip8/industrial_calibration
that referenced
this pull request
Nov 14, 2023
marip8
added a commit
to marip8/industrial_calibration
that referenced
this pull request
Nov 14, 2023
marip8
added a commit
to marip8/industrial_calibration
that referenced
this pull request
Nov 14, 2023
marip8
added a commit
to marip8/industrial_calibration
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare corner relative sizes rather than absolute sizes