Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function names in R/cleanup.R file #38

Closed
Seyi007 opened this issue Oct 5, 2024 · 2 comments · Fixed by #61
Closed

Rename function names in R/cleanup.R file #38

Seyi007 opened this issue Oct 5, 2024 · 2 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request outreachy for outreachy interns

Comments

@Seyi007
Copy link
Collaborator

Seyi007 commented Oct 5, 2024

          [R/cleanup.R](https://github.com/JRaviLab/MolEvolvR/blob/main/R/cleanup.R)
Original Modified User Facing
clean_string cleanString
string2accnum extractAccessionNumber
make_accnums_unique ensureUniqueAccessionNumbers
cleanup_fasta_header cleanFAHeaders
remove_empty removeEmptyRows
repeat2s condenseRepeatedDomains
replaceQMs replaceQuestionMarks
remove_astrk removeAsterisks
remove_tails removeTails
cleanup_species cleanSpecies
cleanup_clust cleanClusters
cleanup_domarch cleanDomainArchitecture
cleanup_gencontext cleanGenomicContext
cleanup_GeneDesc cleanGeneDescription
pick_longer_duplicate selectLongestDuplicate
cleanup_lineage cleanLineage

Originally posted by @the-mayer in #7 (comment)

All updates should follow this format:

Original Modified User Facing
original_function newFunction

NOTE: Before beginning to work on a particular file, please check to see that @jananiravi has given the 👍 on the comment.

Please follow the contributing guidelines and create a new branch containing your changes. Commit your work, and submit a PR when ready for review.

Additionally, use the search in all files functionality in VS code, Rstudio, or any other text editor, and list all files the function is being called or used to be updated later.

@Seyi007 Seyi007 added enhancement New feature or request outreachy for outreachy interns labels Oct 5, 2024
@teddyCodex
Copy link
Collaborator

Hi @jananiravi @Seyi007 Can you assign this to me?

@jananiravi
Copy link
Member

@teddyCodex @Seyi007, please use the updated names from #7.

@the-mayer the-mayer linked a pull request Oct 7, 2024 that will close this issue
11 tasks
the-mayer added a commit that referenced this issue Oct 7, 2024
Refactored function names in R/cleanup.R
- fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outreachy for outreachy interns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants