Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored function names in R/cleanup.R #61

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified function names in R/cleanup.R based on issue #7

Original Modified User Facing
clean_string cleanString
string2accnum extractAccNum
make_accnums_unique ensureUniqAccNum
cleanup_fasta_header cleanFAHeaders
remove_empty removeEmptyRows
repeat2s condenseRepeatedDomains
replaceQMs replaceQuestionMarks
remove_astrk removeAsterisks
remove_tails removeTails
cleanup_species cleanSpecies
cleanup_clust cleanClusters
cleanup_domarch cleanDomainArchitecture
cleanup_gencontext cleanGenomicContext
cleanup_GeneDesc cleanGeneDescription
pick_longer_duplicate selectLongestDuplicate
cleanup_lineage cleanLineage

Fixes issue #38

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex teddyCodex force-pushed the issue-38-rename-functions branch from 61680ae to e004cd4 Compare October 6, 2024 19:30
@teddyCodex
Copy link
Collaborator Author

@jananiravi @the-mayer
File containing other occurrences of the functions.

function_occurrences #38.txt

@teddyCodex teddyCodex marked this pull request as ready for review October 6, 2024 19:31
@the-mayer the-mayer linked an issue Oct 7, 2024 that may be closed by this pull request
@the-mayer
Copy link
Collaborator

the-mayer commented Oct 7, 2024

Resolved NAMESPACE conflict, updated cleanString() refs. Merging!

@the-mayer the-mayer merged commit 4a4efa6 into JRaviLab:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename function names in R/cleanup.R file
2 participants