Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function names in R/cleanup.R #58

Closed

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified functions in R/cleanup.R based on issue #7

Original Modified User Facing
clean_string cleanString
string2accnum extractAccessionNumber
make_accnums_unique ensureUniqueAccessionNumbers
cleanup_fasta_header cleanUpFastaHeaders
remove_empty removeEmptyRows
repeat2s condenseRepeatedDomains
replaceQMs replaceQuestionMarks
remove_astrk removeAsterisks
remove_tails removeLowFrequencyEntries
cleanup_species cleanUpSpeciesColumn
cleanup_clust cleanUpClusterData
cleanup_domarch cleanUpDomainArchitecture
cleanup_gencontext cleanUpGenomicContextColumn
cleanup_GeneDesc cleanUpGeneDescription
pick_longer_duplicate selectLongestDuplicateRecord
cleanup_lineage cleanUpLineageData

Fixes issue #38

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex
Copy link
Collaborator Author

teddyCodex commented Oct 6, 2024

@jananiravi @the-mayer
File containing other occurrences of the functions. Please let me know if I should commit this file as well.

function_occurrences #38.txt

@teddyCodex teddyCodex requested review from the-mayer, Seyi007 and jananiravi and removed request for Seyi007, the-mayer and jananiravi October 6, 2024 17:56
@teddyCodex teddyCodex closed this Oct 6, 2024
@teddyCodex teddyCodex deleted the issue-38-rename-functions branch October 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant