3609 large guestbooks #4057
Merged
3609 large guestbooks #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May require/benefit from further optimizations though. [#3609]
…liminating the extra lookup for custom questions and answers, that was adding one extra query per every guestbookresponse in the search results. (#3609)
… guestbook data. Lots of optimizations and fixes. Will add more info in #3609 explaining what's been done and how things are supposed to work now.
…ed up the display limit to 5K. (#3609)
…et Guestbook and Guestbook Responses pgs. [ref #3609]
Minor edits to messaging for clarity and brevity
…t permission on the dataverse (similar to how manage-guestbooks operates).
|
|
||
| queryString += " order by r.id desc"; | ||
|
|
||
| if (limit != null) { |
There was a problem hiding this comment.
do we ever want to querry with non null limits? if not limit shoud be long
pdurbin
requested changes
Aug 15, 2017
…to change the display limit on the number of guestbook entries. (#3609)
| @@ -1052,7 +1052,7 @@ dataset.manageGuestbooks.tab.header.date=Date Created | |||
| dataset.manageGuestbooks.tab.header.usage=Usage | |||
| dataset.manageGuestbooks.tab.header.responses=Responses | |||
| dataset.manageGuestbooks.tab.header.action=Action | |||
| dataset.manageGuestbooks.tab.action.btn.view=View | |||
| dataset.manageGuestbooks.tab.action.btn.view=Preview | |||
There was a problem hiding this comment.
don't use this. Use preview in the bundle.
pdurbin
approved these changes
Aug 15, 2017
pdurbin
added this to the 4.8 - AWS S3 Support and Large Data Upload Integration milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist