Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3609 large guestbooks #4057

Merged
merged 16 commits into from
Aug 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4eb80d1
Reimplemented the download-guestbook-responses-as-CSV to use streaming.
landreev Aug 8, 2017
0dfe288
Further improved the performance of the guestbook-responses page, by …
landreev Aug 9, 2017
38af5c9
Finalized (hopefully) reworking of the view-and-download of collected…
landreev Aug 10, 2017
9b3fff0
fixed a small bug; changed the help message on the results page; bump…
landreev Aug 10, 2017
39fa4d5
Merge branch 'develop' into 3609-large-guestbooks
mheppler Aug 11, 2017
e3588d3
Cleaned up layout of various buttons, popups and text in Manage Datas…
mheppler Aug 14, 2017
a2b3b55
Cleaned up layout of warning msg in Guestbook Responses pgs. [ref #3609]
mheppler Aug 14, 2017
e940814
Edits to Guestbook messaging + warning [ref: #3609]
dlmurphy Aug 14, 2017
32be0cb
Made the guestbook-responses page viewable only to users with the edi…
landreev Aug 14, 2017
9dc46ae
Returned View Responses button to Guestbook pg. [ref #3609]
mheppler Aug 14, 2017
b05a026
Some extra cleanup/streamlining of code for #3609.
landreev Aug 15, 2017
e869900
add script to insert many guestbook responses #3609
pdurbin Aug 15, 2017
f5d1b53
Cleaned up layout of Preview Guestbook popup on dataset pg. [ref #3609]
mheppler Aug 15, 2017
fd5c44c
added the settings section in the configuration guide explaining how …
landreev Aug 15, 2017
51d408a
made some fields that didn't need to be public private. (#3609)
landreev Aug 15, 2017
bbf405a
move script to more semantic location #3609
pdurbin Aug 15, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/sphinx-guides/source/installation/config.rst
Original file line number Diff line number Diff line change
Expand Up @@ -929,3 +929,10 @@ This setting is experimental and to be used with the Data Capture Module (DCM).
++++++++++++++++

This setting is experimental and related to Repository Storage Abstraction Layer (RSAL). As of this writing it has no effect.

:GuestbookResponsesPageDisplayLimit
+++++++++++++++++++++++++++++++++++

Limit on how many guestbook entries to display on the guestbook-responses page. By default, only the 5000 most recent entries will be shown. Use the standard settings API in order to change the limit. For example, to set it to 10,000, make the following API call:

``curl -X PUT -d 10000 http://localhost:8080/api/admin/settings/:GuestbookResponsesPageDisplayLimit``
5 changes: 5 additions & 0 deletions scripts/issues/guestbook/insert-guestbook-responses.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-- select * from guestbookresponse;
-- 150K would be a better test, see https://github.com/IQSS/dataverse/issues/3609#issuecomment-322559209
--for i in {0..2000}; do psql dataverse_db -f scripts/issues/3845/insert-guestbook-responses.sh; done
-- id | downloadtype | email | institution | name | position | responsetime | sessionid | authenticateduser_id | datafile_id | dataset_id | datasetversion_id | guestbook_id
insert into guestbookresponse values (default, 1, null, null, null, null, null, null, null, 104, 103, null, 2);
23 changes: 15 additions & 8 deletions src/main/java/Bundle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1052,16 +1052,17 @@ dataset.manageGuestbooks.tab.header.date=Date Created
dataset.manageGuestbooks.tab.header.usage=Usage
dataset.manageGuestbooks.tab.header.responses=Responses
dataset.manageGuestbooks.tab.header.action=Action
dataset.manageGuestbooks.tab.action.btn.view=View
dataset.manageGuestbooks.tab.action.btn.view=Preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use this. Use preview in the bundle.

dataset.manageGuestbooks.tab.action.btn.copy=Copy
dataset.manageGuestbooks.tab.action.btn.enable=Enable
dataset.manageGuestbooks.tab.action.btn.disable=Disable
dataset.manageGuestbooks.tab.action.btn.edit=Edit
dataset.manageGuestbooks.tab.action.btn.viewCollectedData=View Collected Data
dataset.manageGuestbooks.tab.action.btn.preview=Preview
dataset.manageGuestbooks.tab.action.btn.viewCollectedData=View Responses
dataset.manageGuestbooks.tab.action.btn.delete=Delete
dataset.manageGuestbooks.tab.action.btn.delete.dialog.header=Delete Guestbook
dataset.manageGuestbooks.tab.action.btn.delete.dialog.tip=Are you sure you want to delete this guestbook? You cannot undelete a guestbook.
dataset.manageGuestbooks.tab.action.btn.view.dialog.header=Dataset Guestbook
dataset.manageGuestbooks.tab.action.btn.view.dialog.header=Preview Guestbook
dataset.manageGuestbooks.tab.action.btn.view.dialog.datasetGuestbook.title=Upon downloading files the guestbook asks for the following information.
dataset.manageGuestbooks.tab.action.btn.view.dialog.datasetGuestbook=Guestbook Name
dataset.manageGuestbooks.tab.action.btn.viewCollectedData.dialog.header=Dataset Guestbook Collected Data
Expand All @@ -1076,13 +1077,20 @@ dataset.manageGuestbooks.message.enableSuccess=The guestbook has been enabled.
dataset.manageGuestbooks.message.enableFailure=The guestbook could not be enabled.
dataset.manageGuestbooks.message.disableSuccess=The guestbook has been disabled.
dataset.manageGuestbooks.message.disableFailure=The guestbook could not be disabled.
dataset.manageGuestbooks.tip.title=Manage Dataset Guestbooks
dataset.manageGuestbooks.tip.downloadascsv=Click \"Download All Responses\" to download all collected guestbook responses for this dataverse, as a CSV file. To navigate and analyze your collected responses, we recommend importing this CSV file into Excel, Google Sheets or similar software.
dataset.guestbooksResponses.dataset=Dataset
dataset.guestbooksResponses.date=Date
dataset.guestbooksResponses.type=Type
dataset.guestbooksResponses.file=File
dataset.guestbooksResponses.tip.title=Guestbook Responses
dataset.guestbooksResponses.count.responses={0} {0, choice, 0#Responses|1#Response|2#Responses}
dataset.guestbooksResponses.count.toofresults={0} to {1} of {2} {2, choice, 0#Responses|1#Response|2#Responses}
dataset.guestbooksResponses.tip.downloadascsv=Click \"Download Responses\" to download all collected responses for this guestbook, as a CSV file. To navigate and analyze your collected responses, we recommend importing this CSV file into Excel, Google Sheets or similar software.
dataset.guestbooksResponses.tooManyResponses.message=Note: this guestbook has too many responses to display on this page. Only the most recent {0} responses are shown below. Click \"Download Responses\" to download all collected responses ({1} total) as a CSV file.

# guestbook-responses.xhtml
dataset.guestbookResponses.pageTitle=View Guestbook Responses
dataset.guestbookResponses.pageTitle=Guestbook Responses

# guestbook.xhtml

Expand All @@ -1091,10 +1099,9 @@ dataset.manageGuestbooks.guestbook.name.tip=Enter a unique name for this Guestbo
dataset.manageGuestbooks.guestbook.dataCollected=Data Collected
dataset.manageGuestbooks.guestbook.dataCollected.description=Dataverse account information that will be collected when a user downloads a file. Check the ones that will be required.
dataset.manageGuestbooks.guestbook.customQuestions=Custom Questions
dataset.manageGuestbooks.guestbook.requiredCustomQuestions=Required Custom Questions
dataset.manageGuestbooks.guestbook.optionalCustomQuestions=Optional Custom Questions
dataset.manageGuestbooks.guestbook.requiredAccountInformation=Required Account Information
dataset.manageGuestbooks.guestbook.optionalAccountInformation=Optional Account Information
dataset.manageGuestbooks.guestbook.accountInformation=Account Information
dataset.manageGuestbooks.guestbook.required=(Required)
dataset.manageGuestbooks.guestbook.optional=(Optional)
dataset.manageGuestbooks.guestbook.customQuestions.description=Create your own questions to have users provide more than their account information when they download a file. Questions can be required or optional and answers can be text or multiple choice.
dataset.manageGuestbooks.guestbook.customQuestions.questionType=Question Type
dataset.manageGuestbooks.guestbook.customQuestions.questionText=Question Text
Expand Down
Loading