Healthcheck notification won't display if task state is TASK_FAILED #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ class taskHealthcheckNotificationSubview extends View | |||
|
|
|||
| render: => | |||
| return if not @model.synced | |||
| return if _.last(@model.attributes.taskUpdates).taskState is "TASK_FAILED" # This is unfortunately the only place last state is stored. | |||
There was a problem hiding this comment.
We are pulling the task state in the same way in other places as well, no need for the comment here. Alternatively, if you want it cleaner here, you could add a line in parse on the model for the task and set an attribute called currentState using the code above. Then we have it for reference later on on each task model that we look at
|
👍 |
| @@ -14,6 +14,7 @@ class taskHealthcheckNotificationSubview extends View | |||
|
|
|||
| render: => | |||
| return if not @model.synced | |||
| return if @model.attributes.lastKnownState is "TASK_FAILED" | |||
Don't display healthcheck message for tasks in state TASK_LOST or TASK_FINISHED
ssalinas
added a commit
that referenced
this pull request
Mar 10, 2016
Healthcheck notification won't display if task state is TASK_FAILED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification that the task failed due to no passing healthchecks was being displayed even for tasks that failed on their own for other reasons.
This fixes that.