Merge pull request #913 from HubSpot/failed_task_healthcheck_message

Healthcheck notification won't display if task state is TASK_FAILED
HubSpot · Mar 10, 2016 · ba2709b · ba2709b
2 parents af8f571 + c16a4f7
commit ba2709b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/SingularityUI/app/models/TaskHistory.coffee b/SingularityUI/app/models/TaskHistory.coffee
@@ -12,6 +12,7 @@ class TaskHistory extends Model
 
     parse: (taskHistory) ->
         taskHistory.taskUpdates = _.sortBy taskHistory.taskUpdates, (t) -> t.timestamp
+        taskHistory.lastKnownState = _.last(taskHistory.taskUpdates).taskState
         taskHistory.healthcheckResults = (_.sortBy taskHistory.healthcheckResults, (t) -> t.timestamp).reverse()
 
         taskHistory.task?.mesosTask?.executor?.command?.environment?.variables = _.sortBy taskHistory.task.mesosTask.executor.command.environment.variables, "name"
@@ -52,7 +53,7 @@ class TaskHistory extends Model
                 taskHistory.slaveMissing = true
 
 
-        taskHistory.isCleaning = _.last( taskHistory.taskUpdates ).taskState is 'TASK_CLEANING'
+        taskHistory.isCleaning = taskHistory.lastKnownState is 'TASK_CLEANING'
 
         taskHistory.requestId = taskHistory.task.taskId.requestId
 

diff --git a/SingularityUI/app/views/taskHealthcheckNotificationSubview.coffee b/SingularityUI/app/views/taskHealthcheckNotificationSubview.coffee
@@ -3,6 +3,12 @@ Task = require '../models/Task'
 
 class taskHealthcheckNotificationSubview extends View
 
+    noHealthcheckMessageStates: [
+        'TASK_FAILED',
+        'TASK_FINISHED',
+        'TASK_LOST'
+    ]
+
     events: ->
         _.extend super,
             'click [data-action="viewHealthchecks"]': 'triggerToggleHealthchecks'
@@ -14,6 +20,7 @@ class taskHealthcheckNotificationSubview extends View
 
     render: =>
         return if not @model.synced
+        return if @model.attributes.lastKnownState in @noHealthcheckMessageStates
         @$el.html @template @renderData()
 
     renderData: =>