Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck notification won't display if task state is TASK_FAILED #913

Merged
merged 5 commits into from
Mar 10, 2016
+9 −1
Merged

Healthcheck notification won't display if task state is TASK_FAILED #913

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e50001
Healthcheck notification won't display if task state is TASK_FAILED
Feb 19, 2016
ad36b5a
Put the lastKnownState attribute into the parse method
Feb 19, 2016
85b3a4b
Change double quotes to single quotes
Feb 19, 2016
7ffb9a1
Tasks in state TASK_LOST or TASK_FINISHED will also not display a hea…
Mar 4, 2016
c16a4f7
Merge pull request #934 from HubSpot/task_status_healthcheck_message
ssalinas Mar 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SingularityUI/app/views/taskHealthcheckNotificationSubview.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class taskHealthcheckNotificationSubview extends View

render: =>
return if not @model.synced
return if _.last(@model.attributes.taskUpdates).taskState is "TASK_FAILED" # This is unfortunately the only place last state is stored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are pulling the task state in the same way in other places as well, no need for the comment here. Alternatively, if you want it cleaner here, you could add a line in parse on the model for the task and set an attribute called currentState using the code above. Then we have it for reference later on on each task model that we look at

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@$el.html @template @renderData()

renderData: =>
Expand Down