Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk 15.0.1 #61226

Closed
wants to merge 8 commits into from
Closed

openjdk 15.0.1 #61226

wants to merge 8 commits into from

Conversation

bayandin
Copy link
Member

Created with brew bump-formula-pr.

@bayandin bayandin changed the title openjdk 36 openjdk 15 Sep 16, 2020
@bayandin bayandin force-pushed the bump-openjdk-36 branch 3 times, most recently from de72539 to ae6fb28 Compare September 16, 2020 17:36
@bayandin
Copy link
Member Author

bayandin commented Sep 17, 2020

Previous failures

10.15 It looks like the most of 10.15 only fails are related to Xcode 12 update

10.14

  • brew audit carrot2 --online --git --skip-style
  • brew install --build-from-source cbmc
  • brew install --build-from-source htmlcleaner
  • brew install --build-from-source komposition
  • brew install --build-from-source parquet-tools
  • brew install --build-from-source vcs
  • brew test --retry --verbose mesos
  • brew test --retry --verbose metabase fixed in metabase: use openjdk@11 #62185
  • brew test --retry --verbose pax-construct
  • brew test --retry --verbose solr@7.7

10.13

  • brew audit carrot2 --online --git --skip-style
  • brew install --build-from-source cbmc
  • brew install --build-from-source htmlcleaner
  • brew install --build-from-source komposition
  • brew install --build-from-source opencv@3
  • brew install --build-from-source parquet-tools
  • brew test --retry --verbose mesos
  • brew test --retry --verbose metabase fixed in metabase: use openjdk@11 #62185
  • brew test --retry --verbose pax-construct
  • brew test --retry --verbose solr@7.7

@bayandin bayandin force-pushed the bump-openjdk-36 branch 3 times, most recently from d92c6b4 to afaf038 Compare October 1, 2020 09:46
@chenrui333 chenrui333 mentioned this pull request Oct 2, 2020
@asbjornu
Copy link
Contributor

asbjornu commented Oct 6, 2020

I'd love to see this merged. Is there any way I can help progress this, @bayandin?

@SMillerDev
Copy link
Member

You can help fix all posted build failures.

@bayandin
Copy link
Member Author

bayandin commented Oct 12, 2020

Fails on all macOS versions:

Additional failures on 10.15 (I believe most of them could be related to Xcode 12 update):

On 10.13:

  • brew install --build-from-source opencv@3: hope it's gonna be ok with updated opencv@3 after opencv@3 3.4.12 #62804
In file included from /tmp/opencv@3-20201011-32209-11qe0p5/opencv-3.4.10/modules/core/include/opencv2/core/hal/intrin.hpp:211:
/tmp/opencv@3-20201011-32209-11qe0p5/opencv-3.4.10/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:151:12: error: always_inline function '_mm_packus_epi32' requires target feature 'sse4.1', but would be inlined into function '_v128_packs_epu32' that is compiled without support for 'sse4.1'
    return _mm_packus_epi32(am, bm);
           ^
/tmp/opencv@3-20201011-32209-11qe0p5/opencv-3.4.10/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:111:1: error: always_inline function '_mm_min_epu32' requires target feature 'sse4.1', but would be inlined into function '_v128_min_epu32' that is compiled without support for 'sse4.1'
OPENCV_HAL_SSE_WRAP_2(min_epu32, __m128i)
^
/tmp/opencv@3-20201011-32209-11qe0p5/opencv-3.4.10/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:21:14: note: expanded from macro 'OPENCV_HAL_SSE_WRAP_2'
    { return _mm_##fun(a, b); }
             ^
<scratch space>:124:1: note: expanded from here
_mm_min_epu32
^
2 errors generated.
make[2]: *** [modules/core/CMakeFiles/opencv_core.dir/src/arithm.cpp.o] Error 1
make[1]: *** [modules/core/CMakeFiles/opencv_core.dir/all] Error 2

@jonchang
Copy link
Contributor

I fixed mercury in #62606, no clue why this run didn't pick it up.

@bayandin
Copy link
Member Author

bayandin commented Oct 12, 2020

I fixed mercury in #62606, no clue why this run didn't pick it up.

It looks like it was merged after tests were triggered (I don't see the patch in my branch).
No worries, we'll need at least one more run (hope only one)

@bayandin
Copy link
Member Author

Also, it seems we need to add --with-sysroot=#{MacOS.sdk_path} to make it possible to build OpenJDK on CLT-only systems

@bayandin
Copy link
Member Author

  • brew install --build-from-source cbmc

Wasn't able to reproduce the same failure, but got a similar problem (diffblue/cbmc#4956) by switching CMake generator to ninja, and applying suggested workaround (-DCMAKE_C_COMPILER=/usr/bin/clang ) helped. Will try to use it, to see it helps.

@bayandin bayandin added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 16, 2020
@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request and removed do not merge labels Oct 16, 2020
@bayandin
Copy link
Member Author

bayandin commented Oct 18, 2020

Ok, we got some progress, but still have some failures:

  • brew install --build-from-source carrot2 should be fixed by carrot2: allow formula to use latest gradle #63059

  • brew install --build-from-source freeswitch

  • brew install --build-from-source kamel

  • brew install --build-from-source komposition

  • brew test --retry --verbose pax-construct

  • brew install --build-from-source opencv@3 only on macOS 10.13

@bayandin
Copy link
Member Author

bayandin commented Oct 23, 2020

Regarding opencv@3 failure on High Sierra:

/tmp/opencv@3-20201017-92788-1i4yuk4/opencv-3.4.12/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:151:12: error: always_inline function '_mm_packus_epi32' requires target feature 'sse4.1', but would be inlined into function '_v128_packs_epu32' that is compiled without support for 'sse4.1'
    return _mm_packus_epi32(am, bm);
           ^
/tmp/opencv@3-20201017-92788-1i4yuk4/opencv-3.4.12/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:111:1: error: always_inline function '_mm_min_epu32' requires target feature 'sse4.1', but would be inlined into function '_v128_min_epu32' that is compiled without support for 'sse4.1'
OPENCV_HAL_SSE_WRAP_2(min_epu32, __m128i)
^
/tmp/opencv@3-20201017-92788-1i4yuk4/opencv-3.4.12/modules/core/include/opencv2/core/hal/intrin_sse_em.hpp:21:14: note: expanded from macro 'OPENCV_HAL_SSE_WRAP_2'
    { return _mm_##fun(a, b); }
             ^
<scratch space>:122:1: note: expanded from here
_mm_min_epu32
^
2 errors generated.

It looks like cmake flags that we set (args << "-DENABLE_SSE41=OFF" << "-DENABLE_SSE42=OFF" unless MacOS.version.requires_sse42?) are inconsistent with what it detects itself:

-- Performing Test HAVE_CPU_SSE4_1_SUPPORT - Success
-- Performing Test HAVE_CPU_POPCNT_SUPPORT (check file: cmake/checks/cpu_popcnt.cpp)
-- Performing Test HAVE_CPU_POPCNT_SUPPORT - Failed
-- Performing Test HAVE_CXX_MPOPCNT (check file: cmake/checks/cpu_popcnt.cpp)
-- Performing Test HAVE_CXX_MPOPCNT - Success
-- Performing Test HAVE_CPU_SSE4_2_SUPPORT (check file: cmake/checks/cpu_sse42.cpp)
-- Performing Test HAVE_CPU_SSE4_2_SUPPORT - Failed

and then

--   CPU/HW features:
--     Baseline:                    SSE SSE2 SSE3 SSSE3 SSE4_1
--       requested:                 DETECT
--       disabled:                  SSE4_1 SSE4_2 AVX AVX2
--     Dispatched code generation:  SSE4_1 SSE4_2 FP16 AVX AVX2 AVX512_SKX
--       requested:                 SSE4_1 SSE4_2 AVX FP16 AVX2 AVX512_SKX
--       SSE4_1 (0 files):          + 
--       SSE4_2 (1 files):          + POPCNT SSE4_2
--       FP16 (0 files):            + POPCNT SSE4_2 FP16 AVX
--       AVX (5 files):             + POPCNT SSE4_2 AVX
--       AVX2 (28 files):           + POPCNT SSE4_2 FP16 FMA3 AVX AVX2
--       AVX512_SKX (4 files):      + POPCNT SSE4_2 FP16 FMA3 AVX AVX2 AVX_512F AVX512_COMMON AVX512_SKX

It happens because Penryn processor (that we have on our High Sierra agents) supports sse4.1 and doesn't support 4.2.

Since opencv suggests to use CPU_BASELINE/CPU_DISPATCH options instead of those we use, I'll try to replace them and hopefully, it became consistent

-- WARNING: Option ENABLE_SSE41='OFF' is deprecated and should not be used anymore
--          Behaviour of this option is not backward compatible
--          Refer to 'CPU_BASELINE'/'CPU_DISPATCH' CMake options documentation
-- WARNING: Option ENABLE_SSE42='OFF' is deprecated and should not be used anymore
--          Behaviour of this option is not backward compatible
--          Refer to 'CPU_BASELINE'/'CPU_DISPATCH' CMake options documentation
-- WARNING: Option ENABLE_AVX='OFF' is deprecated and should not be used anymore
--          Behaviour of this option is not backward compatible
--          Refer to 'CPU_BASELINE'/'CPU_DISPATCH' CMake options documentation
-- WARNING: Option ENABLE_AVX2='OFF' is deprecated and should not be used anymore
--          Behaviour of this option is not backward compatible
--          Refer to 'CPU_BASELINE'/'CPU_DISPATCH' CMake options documentation

@jonchang
Copy link
Contributor

komposition: #63449

@jonchang jonchang force-pushed the bump-openjdk-36 branch 2 times, most recently from 6b80403 to 312bfe5 Compare October 26, 2020 04:28
@bayandin bayandin force-pushed the bump-openjdk-36 branch 3 times, most recently from 20ca438 to 9ae9306 Compare October 27, 2020 17:13
@bayandin
Copy link
Member Author

cmus broken linkage should be fixed by #63595

@bayandin bayandin changed the title openjdk 15 openjdk 15.0.1 Oct 28, 2020
@bayandin
Copy link
Member Author

There're only 2 failed tests on High Sierra: already known opencv@3 and synfig with some random download error:

==> FAILED
==> Downloading https://downloads.sourceforge.net/project/synfig/releases/1.2.2/source/synfig-1.2.2.tar.gz
==> Downloading from https://master.dl.sourceforge.net/project/synfig/releases/1.2.2/source/synfig-1.2.2.tar.gz
curl: (22) The requested URL returned error: 503 Service Unavailable
Error: Failed to download resource "synfig"

@jonchang I believe we're finally ready to merge it 🎉

@jonchang
Copy link
Contributor

Yeah let's do it 😅

@BrewTestBot
Copy link
Member

:shipit: @jonchang has triggered a merge.

@bayandin bayandin deleted the bump-openjdk-36 branch October 30, 2020 10:14
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 2, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants