Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gegl: fix build from source with meson nofallback #62603

Closed
wants to merge 1 commit into from
Closed

gegl: fix build from source with meson nofallback #62603

wants to merge 1 commit into from

Conversation

jonchang
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Needed for #61226 as a result of Homebrew/brew#8649. Since basically only gegl uses libnsgif and poly2tri-c, they ship the source as part of their distribution tarballs. Re-enable fallbacks for these vendored dependencies since they won't be downloaded separately.

@jonchang jonchang requested a review from tschoonj October 10, 2020 06:37
@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Oct 10, 2020
@jonchang
Copy link
Contributor Author

jonchang commented Oct 10, 2020

GEGL is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License and GNU General Public License as published by the Free Software Foundation; either version 3 of the Licenses, or (at your option) any later version. The library itself is licensed under LGPL while the sample commandline application and GUI binary gegl is licensed under GPL. GEGL depends on and ships with the Poly2Tri-C library, which is also free software; you can redistribute it and/or modify it under the terms of the New BSD License.

https://www.gegl.org/copyright.html

libnsgif is MIT licensed: https://gitlab.gnome.org/GNOME/gegl/-/blob/master/subprojects/libnsgif/COPYING

@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Oct 10, 2020
Copy link
Contributor

@tschoonj tschoonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@jonchang jonchang deleted the gegl-meson-fallback branch November 10, 2020 03:32
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants