Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesos 1.10.0 #61945

Closed
wants to merge 1 commit into from
Closed

mesos 1.10.0 #61945

wants to merge 1 commit into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Oct 2, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Oct 2, 2020
@BrewTestBot BrewTestBot removed the python Python use is a significant feature of the PR or issue label Oct 3, 2020
@SMillerDev
Copy link
Member

@bayandin is this ready for review?

@bayandin
Copy link
Member Author

bayandin commented Oct 5, 2020

@bayandin is this ready for review?

Let me check if we can update resources first

@bayandin
Copy link
Member Author

bayandin commented Oct 6, 2020

I think we can proceed with the current versions of resources since all of them are needed to build protobuf package for python, but mesos uses a bundled version of protobuf (3.5.0), so the resource looks even too new, but if it works then it works.

Regarding bundled dependencies, mesos has a number of them: https://github.com/apache/mesos/tree/1.10.0/3rdparty (and most of them are outdated compared to homebrews versions, not to mention that mesos uses python 2.7 and java 1.8).
I've tried to replace some of the bundled dependencies with homebrews one, but it fails. So I believe it deserves a separate PR.

@bayandin bayandin marked this pull request as ready for review October 6, 2020 09:58
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@bayandin bayandin deleted the bump-mesos-1.10.0 branch October 6, 2020 10:23
@bayandin bayandin mentioned this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants