Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 3.12.3 #55750

Closed
wants to merge 2 commits into from
Closed

Conversation

anderscarling
Copy link
Contributor

Created with brew bump-formula-pr.

@anderscarling
Copy link
Contributor Author

Version of resource "six" bumped to version 1.15.0 as per discussion in #55423.
Hash and download url fetched from https://pypi.org/project/six/#files

@anderscarling
Copy link
Contributor Author

I think this will be fixed by a rebuild of libphonenumber - as the phonenumber.pb.h file seems to be generated at build time. I guess we should bump revision on that formula?

==> FAILED
161
Testing libphonenumber
162
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200603-78079-1vofq8c.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/libphonenumber.rb --verbose
163
==> /usr/bin/clang++ -std=c++11 test.cpp -L/usr/local/Cellar/libphonenumber/8.12.4_2/lib -lphonenumber -o test
In file included from test.cpp:1:
In file included from /usr/local/include/phonenumbers/phonenumberutil.h:31:
/usr/local/include/phonenumbers/phonenumber.pb.h:47:51: error: no type named 'AuxillaryParseTableField' in namespace 'google::protobuf::internal'; did you mean 'AuxiliaryParseTableField'?
  static const ::PROTOBUF_NAMESPACE_ID::internal::AuxillaryParseTableField aux[]
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
                                                  AuxiliaryParseTableField

@Moisan
Copy link
Member

Moisan commented Jun 4, 2020

Could you squash together your first and second commit with the first commit message (protobuf 3.12.3)? We prefer to keep one commit per formula. After that it should be ready to merge.

@dawidd6 dawidd6 added the almost there PR is nearly ready to merge label Jun 4, 2020
@anderscarling
Copy link
Contributor Author

@Moisan Done!

@anderscarling
Copy link
Contributor Author

Error seems to be a coding problem in homebrew audit cmd:

Error: undefined local variable or method `release' for #<Homebrew::FormulaAuditor:0x00007ffdce1d9c90>
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:701:in `audit_specs'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:932:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:925:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:925:in `audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:122:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:115:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:115:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'

@anderscarling
Copy link
Contributor Author

When fixing the issue manually (by replacing release with @release on line 701 and 702 in audit.rb), the style check is successful on my machine.

@Moisan
Copy link
Member

Moisan commented Jun 4, 2020

I think the issue was solved since then, I'll relaunch the CI.

@Moisan
Copy link
Member

Moisan commented Jun 4, 2020

The issue is still present so I opened PR Homebrew/brew#7689
Thanks for the pointer how to solve this 👍 .

@flosell flosell mentioned this pull request Jun 4, 2020
5 tasks
@Moisan Moisan removed the almost there PR is nearly ready to merge label Jun 5, 2020
Copy link
Member

@Moisan Moisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anderscarling ! Without people like you, we couldn't run this project.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants