Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit online release variable #7689

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jun 4, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#7685 changed the release variable but not the following lines leading to this error currently when using brew audit --online:

Error: undefined local variable or method `release' for #<Homebrew::FormulaAuditor:0x00007fb5c7b89a28>

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! The @ was a typo here; I've suggested I think a slightly better fix.

Library/Homebrew/dev-cmd/audit.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/audit.rb Outdated Show resolved Hide resolved
@Moisan Moisan force-pushed the fix_audit_release branch from 4927ca3 to 7a285cf Compare June 4, 2020 13:09
@Bo98 Bo98 merged commit 49324ad into Homebrew:master Jun 4, 2020
@Bo98
Copy link
Member

Bo98 commented Jun 4, 2020

Thanks!

@Moisan Moisan deleted the fix_audit_release branch June 4, 2020 14:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants