Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/audit: don't check GitHub releases without --online. #7685

Merged
merged 1 commit into from
Jun 4, 2020
Merged

dev-cmd/audit: don't check GitHub releases without --online. #7685

merged 1 commit into from
Jun 4, 2020

Conversation

MikeMcQuaid
Copy link
Member

This both is more accurate and making brew audit without --online a bit faster.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This both is more accurate and making `brew audit` without `--online` a
bit faster.
@MikeMcQuaid MikeMcQuaid merged commit 0af7a28 into Homebrew:master Jun 4, 2020
@MikeMcQuaid MikeMcQuaid deleted the audit_releases_online branch June 4, 2020 08:47
@Moisan Moisan mentioned this pull request Jun 4, 2020
6 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants