Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS builds are failing #420

Closed
traversaro opened this issue Jun 8, 2020 · 8 comments
Closed

macOS builds are failing #420

traversaro opened this issue Jun 8, 2020 · 8 comments

Comments

@traversaro
Copy link
Member

The error is:

/usr/local/Cellar/gazebo10/10.2.0_3/include/gazebo-10/gazebo/msgs/camerasensor.pb.h:54:51: error: no type named 'AuxillaryParseTableField' in namespace 'google::protobuf::internal'; did you mean 'AuxiliaryParseTableField'?
  static const ::PROTOBUF_NAMESPACE_ID::internal::AuxillaryParseTableField aux[]
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/usr/local/include/google/protobuf/generated_message_table_driven.h:141:7: note: 'AuxiliaryParseTableField' declared here
union AuxiliaryParseTableField {

probably it is a Gazebo/Homebrew regression.

@traversaro
Copy link
Member Author

traversaro commented Jun 9, 2020

Upstream bug: osrf/homebrew-simulation#1042 .

@nunoguedelha
Copy link
Collaborator

Side info on osrf/homebrew-simulation#1042:

Apparently a symbol was renamed in protobuf's most recent patch release protocolbuffers/protobuf#7496 (merged into homebrew in Homebrew/homebrew-core#55750), so we'll need to rebuild the ignition-msgs* bottles, but I think downstream bottles won't need to be rebuilt.

The problem occurs in two places:

As far as I understood, it occurs:

A way to check you have the fix in your release is doing:

> brew test ignition-msgs1
> brew test ignition-msgs5

should return no error.

  • but also in the Gazebo code itself.

The solution is either to install Gazebo9 from source:

brew install --build-from-source gazebo9

Either to install Gazebo 11 from homebrew:

brew install gazebo11

Indeed Gazebo 11 release 11.0.0_2 has the fix.

I'm trying to rebuild the superbuild now...

@nunoguedelha
Copy link
Collaborator

traversaro added a commit to robotology/gazebo-yarp-plugins that referenced this issue Jun 26, 2020
As Gazebo 9 and 10 have been broken on homebrew for a long time (see robotology/robotology-superbuild#420) I think it is just more productive to switch the CI to use Gazebo 11 on macOS . 

Further improvements: 
* Test compilation also on Ubuntu 20.04  
* Use release branches of YARP and YCM instead of the legacy devel  branches that are not going to be updated anymore
@traversaro
Copy link
Member Author

For the CI, I fixed by migrating everything to Gazebo11, as Gazebo9/10 remains broken. Should we recommend to install Gazebo 11 on macOS in the installation instructions and close this issue?

traversaro added a commit to robotology/gazebo-yarp-plugins that referenced this issue Jun 26, 2020
* Fix GitHub Action CI on macOS and other improviments

As Gazebo 9 and 10 have been broken on homebrew for a long time (see robotology/robotology-superbuild#420) I think it is just more productive to switch the CI to use Gazebo 11 on macOS . 

Further improvements: 
* Test compilation also on Ubuntu 20.04  
* Use release branches of YARP and YCM instead of the legacy devel  branches that are not going to be updated anymore
@traversaro
Copy link
Member Author

For the CI, I fixed by migrating everything to Gazebo11, as Gazebo9/10 remains broken. Should we recommend to install Gazebo 11 on macOS in the installation instructions and close this issue?

I guess that it is ok. If anyone feel strongly otherwise, feel free to comment so we can re-open the issue.

@nunoguedelha
Copy link
Collaborator

For the CI, I fixed by migrating everything to Gazebo11, as Gazebo9/10 remains broken. Should we recommend to install Gazebo 11 on macOS in the installation instructions and close this issue?

Yes, sure @traversaro , sorry for the delay. Although I'm still having issues running Gazebo11 on Catalina.

@nunoguedelha
Copy link
Collaborator

I'll open a separate issue for that if necessary.

@traversaro
Copy link
Member Author

I'll open a separate issue for that if necessary.

Thanks, that would be ideal. This issue was mostly related to the macOS builds failure in CI, and those were fixed by migrating to Gazebo 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants