protobuf: apply upstream fix for thread-local variables #133623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2023
This allows us to use the latest `protobuf` with `libphonenumber`. See Homebrew#133508. It likely also allows us to use a newer `protobuf` and `grpc` in `apache-arrow`. See apache/arrow#35987.
carlocab
force-pushed
the
protobuf-thread-local
branch
from
e4a241b to
acb55a1
Compare
SMillerDev
approved these changes
Jun 14, 2023
Bo98
approved these changes
Jun 14, 2023
|
Thanks for this @carlocab ! |
chenrui333
approved these changes
Jun 14, 2023
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This allows us to use the latest
protobufwithlibphonenumber.See #133508.
It likely also allows us to use a newer
protobufandgrpcinapache-arrow. See apache/arrow#35987.