-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libphonenumber 8.13.14 #133508
libphonenumber 8.13.14 #133508
Conversation
Formula/libphonenumber.rb
Outdated
@@ -2,10 +2,9 @@ class Libphonenumber < Formula | |||
desc "C++ Phone Number library by Google" | |||
homepage "https://github.com/google/libphonenumber" | |||
# TODO: Check if we can use unversioned `protobuf` at version bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tried this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for #128510 to merge.
Signed-off-by: Rui Chen <rui@chenrui.dev>
Cherry-picked onto #128294. |
I think I have a fix for new |
Ok, that worked. Let me try an upstream fix... |
This allows us to use the latest `protobuf` with `libphonenumber`. See Homebrew#133508. It likely also allows us to use a newer `protobuf` and `grpc` in `apache-arrow`. See apache/arrow#35987.
Closes Homebrew#133508. Co-authored-by: Rui Chen <rui@chenrui.dev>
Closed by #133745. |
Created by
brew bump
Created with
brew bump-formula-pr
.