Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber 8.13.14 #133508

Closed

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added java Java use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Jun 13, 2023
@@ -2,10 +2,9 @@ class Libphonenumber < Formula
desc "C++ Phone Number library by Google"
homepage "https://github.com/google/libphonenumber"
# TODO: Check if we can use unversioned `protobuf` at version bump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tried this?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #128510 to merge.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 13, 2023
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 13, 2023
@carlocab
Copy link
Member

Cherry-picked onto #128294.

@carlocab carlocab closed this Jun 14, 2023
@carlocab
Copy link
Member

I think I have a fix for new protobuf. Reopening for testing.

@carlocab carlocab reopened this Jun 14, 2023
@carlocab carlocab marked this pull request as draft June 14, 2023 07:25
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 14, 2023
@carlocab
Copy link
Member

Ok, that worked. Let me try an upstream fix...

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jun 14, 2023
This allows us to use the latest `protobuf` with `libphonenumber`.
See Homebrew#133508.

It likely also allows us to use a newer `protobuf` and `grpc` in
`apache-arrow`. See apache/arrow#35987.
carlocab pushed a commit to carlocab/homebrew-core that referenced this pull request Jun 15, 2023
Closes Homebrew#133508.

Co-authored-by: Rui Chen <rui@chenrui.dev>
@carlocab
Copy link
Member

Closed by #133745.

@carlocab carlocab closed this Jun 15, 2023
@chenrui333 chenrui333 deleted the bump-libphonenumber-8.13.14 branch January 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. boost Boost use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants