Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-arrow, apache-arrow-glib 12.0.1 #133496

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

raulcd
Copy link
Contributor

@raulcd raulcd commented Jun 13, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@raulcd
Copy link
Contributor Author

raulcd commented Jun 13, 2023

@carlocab @chenrui333 can you help me adding the: long build, CI-long-timeout labels?
Thanks!

@carlocab
Copy link
Member

We need to wait for #128510 to merge to avoid introducing a merge conflict there.

@carlocab carlocab added long build Set a long timeout for formula testing boost Boost use is a significant feature of the PR or issue labels Jun 13, 2023
@carlocab
Copy link
Member

Should be good now. Please rebase. Thanks!

Incidentally: are you sure your revision bumps are necessary?

@carlocab
Copy link
Member

Based on local testing (on Linux): I don't think your revision bumps are needed.

@carlocab carlocab force-pushed the apache-arrow-12.0.1 branch from d843b20 to 0a1718c Compare June 14, 2023 07:30
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing and removed long build Set a long timeout for formula testing labels Jun 14, 2023
@carlocab
Copy link
Member

carlocab commented Jun 14, 2023

We might be able to use a newer protobuf/grpc after #133623.

@carlocab carlocab removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Jun 14, 2023
@github-actions github-actions bot added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jun 14, 2023
@carlocab carlocab force-pushed the apache-arrow-12.0.1 branch from 0a1718c to 85b003b Compare June 14, 2023 16:47
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 14, 2023
@carlocab
Copy link
Member

Ah, looks like a bunch of other formulae will need switching to a newer Protobuf/gRPC too. Let's ship the version bump for now, and I'll open a new PR for the other changes after.

@carlocab carlocab force-pushed the apache-arrow-12.0.1 branch from 85b003b to 6901890 Compare June 14, 2023 17:38
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 14, 2023
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 14, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 14, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 14, 2023 23:45
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 14, 2023
Merged via the queue into Homebrew:master with commit 8b5b0a0 Jun 15, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants