Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/shared_audits.rb: check version :all for non-cask formulae in the prerelease allowlist #9427

Closed
wants to merge 3 commits into from
Closed

utils/shared_audits.rb: check version :all for non-cask formulae in the prerelease allowlist #9427

wants to merge 3 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Dec 5, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

All gron releases are pre-releases: https://github.com/tomnomnom/gron/releases

While adding this formula to the prerelease allowlist, I spotted that :all version was only used for casks.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-08 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 5, 2020
reitermarkus
reitermarkus reviewed Dec 5, 2020
View reviewed changes
Library/Homebrew/utils/shared_audits.rb
@@ -59,7 +60,8 @@ def github_release(user, repo, tag, formula: nil, cask: nil)
end

if release["prerelease"]
return if formula && GITHUB_PRERELEASE_ALLOWLIST[formula.name] == formula.version
return if formula && (GITHUB_PRERELEASE_ALLOWLIST[formula.name] == formula.version ||
GITHUB_PRERELEASE_ALLOWLIST[formula.name] == :all)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably also fail if it's not a pre-release anymore but still in the GITHUB_PRERELEASE_ALLOWLIST like above.

miccal
miccal reviewed Dec 5, 2020
View reviewed changes
Library/Homebrew/utils/shared_audits.rb Outdated
@@ -46,6 +46,7 @@ def github_release_data(user, repo, tag)
"telegram-cli" => "1.3.1",
"toggl-track" => :all,
"volta" => "0.8.6",
"gron" => :all,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be picky, but would you mind putting this in alphabetical order? I regularly add Casks to this list, and having them in alphabetical order really helps. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Moisan.

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 8, 2020
@MikeMcQuaid
Copy link
Member

@Moisan Can you rebase this and shout if/when it's ready? Thanks!

@Rylan12
Copy link
Member

Rylan12 commented Dec 28, 2020

I don't think this is needed anymore. The logic was modified in #10087 and the lists were migrated to their respective taps. Formulae should not have the ability to specify all by adding this line to $(brew --repo homebrew/core)/audit_exceptions/github_prerelease_allowlist.json:

{
  ...
  "gron": "all",
  ...
}

@Moisan
Copy link
Member Author

Moisan commented Dec 28, 2020

Perfect, I'll close this PR and open one to add gron to the pre-release list in homebrew-core.

@Moisan Moisan closed this Dec 28, 2020
@Moisan Moisan mentioned this pull request Jan 9, 2021
Merged
5 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miccal miccal miccal left review comments

@reitermarkus reitermarkus reitermarkus left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Moisan @BrewTestBot @MikeMcQuaid @Rylan12 @reitermarkus @miccal