audit: migrate shared audits to taps #10087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2020-12-22 at 19:53:34 UTC. |
BrewTestBot
added
the
waiting for feedback
This was referenced Dec 21, 2020
MikeMcQuaid
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
A few style suggestions but looks good to me, nice work again @Rylan12!
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 22, 2020
|
Changes have been merged in homebrew/core (and made it to linuxbrew-core) and homebrew/cask, so this is good to go! And, good news: I think this is the last migration PR 🥳🎉! |
Closed
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?This is the final (I think) step in the migration of formula/cask lists to their respective taps. Here are the three lists that are modified by this PR:
GITHUB_PRERELEASE_ALLOWLISTis being split and migrated to the homebrew/core and homebrew/cask tapsGITLAB_PRERELEASE_ALLOWLISTis being migrated to the homebrew/core and homebrew/cask taps. It's currently empty but I've migrated them so maintainers know it is an option. Alternatively, it can be deleted and re-added when (if) it's needed.GITHUB_FORK_ALLOWLISTis being removed. This was only used for new formulae and casks, so it doesn't need to be in a list. If we want to allow a fork when adding new formulae/casks, I think we should just ignore the audit. It doesn't make sense to add to a list that will never be used again.As always, there will be corresponding PRs in homebrew/core (Homebrew/homebrew-core#67384) and homebrew/cask (Homebrew/homebrew-cask#96469) to add these lists. Those should be merged before this PR.