Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gron: add to github prerelease audit_exceptions #68604

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jan 9, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Following Homebrew/brew#9427, thir PR adds gron the to the Github prerelease allowlist since all its releases are currently tagged as prerelease. After this is merged, I'll trigger a Big Sur bottle build as explained in #64785 since it's the only reason the bottle creation failed.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 9, 2021
@SMillerDev
Copy link
Member

Please also ask upstream if all their releases aren't meant to be stable, in that case it should probably be removed instead.

@Moisan
Copy link
Member Author

Moisan commented Jan 9, 2021

I added a comment to an existing issue on the subject: tomnomnom/gron#81 .

@chenrui333
Copy link
Member

relates to #69801

@Moisan Moisan merged commit 59333bf into Homebrew:master Jan 26, 2021
@Moisan Moisan deleted the gron_prerelease_audit branch January 26, 2021 23:45
@Moisan
Copy link
Member Author

Moisan commented Jan 26, 2021

I merged this for now since upstream is not responsive on that point, we can always remove the exception later.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants