-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: using the hathor prefix on verifyMessage #426
refactor: using the hathor prefix on verifyMessage #426
Conversation
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 40 40
Lines 2458 2458
Branches 278 278
=======================================
Hits 2350 2350
Misses 108 108
|
@@ -54,6 +54,10 @@ import { | |||
} from '@tests/utils'; | |||
import fullnode from '@src/fullnode'; | |||
|
|||
// Monkey patch bitcore-lib | |||
|
|||
bitcore.Message.MAGIC_BYTES = Buffer.from('Hathor Signed Message:\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using bitcoinjs for verification, do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the lib is using bitcore-lib, I thought it would be a good idea to also use bitcore-lib to generate the mesages
Acceptance Criteria
Security Checklist