feat: sign message

[andreabadesso]

Acceptance Criteria

• We should have a signMessageWIthAddress method on both facades

Security Checklist

• Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

[codecov]

Codecov Report

Merging #546 (b8d00ff) into dev (eeca035) will increase coverage by 15.29%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              dev     #546       +/-   ##
===========================================
+ Coverage   62.64%   77.94%   +15.29%     
===========================================
  Files          67       67               
  Lines        5209     5227       +18     
  Branches     1103     1103               
===========================================
+ Hits         3263     4074      +811     
+ Misses       1853     1142      -711     
+ Partials       93       11       -82     

Impacted Files	Coverage Δ
src/constants.ts	100.00% <100.00%> (ø)
src/models/network.ts	100.00% <100.00%> (ø)
src/new/wallet.js	95.63% <100.00%> (+59.97%)	⬆️
src/utils/crypto.ts	94.59% <100.00%> (+0.84%)	⬆️
src/wallet/wallet.ts	59.74% <100.00%> (+0.39%)	⬆️

... and 23 files with indirect coverage changes

[pedroferreira1]

Do we use this Message class from bitcore for anything in the wallet service facade here in the lib?

I remember we were using it in the wallet service code before changing the library there.

[andreabadesso]

We do use bitcore-message to prove we own the xpub and the authXpub in wallet-service here

We can and probably should use the new utils/crypto.ts method, but I suggest we don't refactor it in this PR as we also need to change wallet-service to expect Hathor Signed Message\n instead of Bitcoin Signed Message\n it currently expect.

[pedroferreira1]

We can and probably should use the new utils/crypto.ts method, but I suggest we don't refactor it in this PR as we also need to change wallet-service to expect Hathor Signed Message\n instead of Bitcoin Signed Message\n it currently expect.

That's my main concern. If we changed the magic bytes for the lib, the current wallets we have in the wallet service wouldn't work anymore, right? Because they were generated using the old magic bytes, or not?

[andreabadesso]

I checked and this is indeed a problem, since we are monkey patching the Message class, it will affect the signMessage for the wallet-service.

I will merge this and work on a fix on the wallet-service side

[andreabadesso]

@pedroferreira1 PR opened in https://github.com/HathorNetwork/hathor-wallet-service/pull/426