#296 Support remote helm chart repositories

[eraac]

Fix #296 based on this #296 (comment)

I added the possibility to skip build dependencies

make test pass, but i have weird error after, maybe someone have an idea ?

PASS
coverage: 94.0% of statements
ok      github.com/GoogleContainerTools/skaffold/pkg/skaffold/yamltags  0.008s  coverage: 94.0% of statements
?       github.com/GoogleContainerTools/skaffold/pkg/webhook/constants  [no test files]
?       github.com/GoogleContainerTools/skaffold/pkg/webhook/github     [no test files]
?       github.com/GoogleContainerTools/skaffold/pkg/webhook/kubernetes [no test files]
?       github.com/GoogleContainerTools/skaffold/pkg/webhook/labels     [no test files]
?       github.com/GoogleContainerTools/skaffold/testutil       [no test files]
?       github.com/GoogleContainerTools/skaffold/webhook        [no test files]
Running validation scripts...
RUN hack/boilerplate.sh
PASSED hack/boilerplate.sh
RUN hack/gofmt.sh
PASSED hack/gofmt.sh
RUN hack/linter.sh
Installing GolangCI-Lint
golangci/golangci-lint info checking GitHub for tag 'v1.9.3'
golangci/golangci-lint info found version: 1.9.3 for v1.9.3/darwin/amd64
golangci/golangci-lint info installed /Users/kevin/Code/go/bin/golangci-lint
WARN [runner/megacheck] Can't run megacheck because of compilation errors in packages [runtime/internal/atomic runtime internal/cpu runtime/internal/sys]: ../../../../../../../../usr/local/Cellar/go/1.11.1/libexec/src/runtime/internal/atomic/atomic_wasm.go:14: Load redeclared in this block and 67 more errors: run `golangci-lint run --no-config --disable-all -E typecheck` to see all errors 
pkg/skaffold/schema/latest/config.go:183:18: struct of size 160 bytes could be of size 152 bytes (maligned)
type HelmRelease struct {
                 ^
...

I have change HelmRelease for implementing this, so it's probably link to this error

[r2d4]

Put the new bool field next to the other bools

[eraac]

@r2d4 fixed :) any explanation?

[codecov-io]

Codecov Report

Merging #1254 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   45.62%   45.63%   +0.01%     
==========================================
  Files         116      116              
  Lines        4870     4871       +1     
==========================================
+ Hits         2222     2223       +1     
  Misses       2424     2424              
  Partials      224      224

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	64.84% <100%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a190f60...d99508c. Read the comment docs.

[r2d4]

Memory gets allocated in 8 byte blocks
Bool takes 1 byte

First grouping of 2 bools had 6 free bytes,
Second grouping of 1 had 7 free bytes

If you move all three together you free up the last block (8 bytes) and use one of the unused spaces!

Kind of a useless linter for skaffold however :)

[eraac]

maybe the option could have a better name, like remoteChart, allowing to use it elsewhere and turn off or on some feature if needed.

waiting for your feedback

[balopat]

1. minor nit around documentation.
2. the double negation is a bit hard to read but I can be convinced
3. would you mind writing unit tests around this behavior covering cases of null/true/false?

[eraac]

1. change done for integration/examples/annoted-skaffold.yaml
2. can be buildDependencies, but should be true by default and I have no idea how to do that
3. job done for true/false, this value can't be null (I think so)

EDIT: unit test not pass on travis, i looking on it
EDIT2: fixed, but not sure to understand this line https://github.com/GoogleContainerTools/skaffold/pull/1254/files#diff-a1535a4f321ed1903fdc7f27ac166432R301 it's a correct value?

[eraac]

@balopat can be the same issue here? #1408 (comment)

[eraac]

Apparently someone has done the work too ... #1368

[faheem-nadeem]

@eraac Any luck getting this figured out or do you need any support on this? Would love to see this merged :)

[eraac]

I am very unlucky with kokoro ...

Get:34 http://archive.ubuntu.com/ubuntu xenial-backports/universe Translation-en [4184 B]
Fetched 18.3 MB in 4s (4046 kB/s)
Reading package lists...
E: Failed to fetch http://storage.googleapis.com/bazel-apt/dists/stable/jdk1.8/binary-amd64/Packages.gz  Hash Sum mismatch
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command '/bin/sh -c apt-get update   && apt-get install -y bazel &&   rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
make: *** [integration-in-docker] Error 100
[ID: 1728516] Build finished after 71 secs, exit value: 2

[skhaz]

Still not working. See #3749

[skhaz]

Thanks for your reply. Unfortunately even with this still not working.

…

On Thu, Feb 27, 2020, 19:44 Labesse Kévin ***@***.***> wrote: You should use key skipBuildDependencies: true Le jeu. 27 févr. 2020 à 22:54, Rodrigo Delduca ***@***.***> a écrit : > Still not working. See #3749 > <#3749> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #1254?email_source=notifications&email_token=ABJ6GFYAOM75X6DCUHDW353RFAZBNA5CNFSM4GCRY5O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGDEEA#issuecomment-592196112 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABJ6GF4SH3JTXCWBG74GTQDRFAZBNANCNFSM4GCRY5OQ > > . > -- Cordialement, Labesse Kevin --- *Le papier est le support de communication le plus naturel, renouvelable et recyclable.Si vous imprimez ce mail, n’oubliez pas de le recycler.* — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1254?email_source=notifications&email_token=AAALJMYJHG3YA332BTU5ID3RFA64FA5CNFSM4GCRY5O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGIAFI#issuecomment-592216085>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALJM322CYQIJFUEEWFVHTRFA64FANCNFSM4GCRY5OQ> .