#296 Support remote helm chart repositories

integration/examples/annotated-skaffold.yaml

@@ -194,6 +194,8 @@ deploy:
     #   namespace: skaffold
     #   version: ""
     #   recreatePods: false
+    #   # set to true if you need to skip "helm dep build". Necessary for use with remote chart.
+    #   skipBuildDependencies: false
     #
     #   # setValues get appended to the helm deploy with --set.
     #   setValues:

pkg/skaffold/deploy/helm.go

@@ -159,10 +159,12 @@ func (h *HelmDeployer) deployRelease(ctx context.Context, out io.Writer, r lates
 		}
 	}
 
-	// First build dependencies.
-	logrus.Infof("Building helm dependencies...")
-	if err := h.helm(ctx, out, "dep", "build", r.ChartPath); err != nil {
-		return nil, errors.Wrap(err, "building helm dependencies")
+	if !r.SkipBuildDependencies {
+		// First build dependencies.
+		logrus.Infof("Building helm dependencies...")
+		if err := h.helm(ctx, out, "dep", "build", r.ChartPath); err != nil {
+			return nil, errors.Wrap(err, "building helm dependencies")
+		}
 	}
 
 	var args []string

pkg/skaffold/deploy/helm_test.go

@@ -155,6 +155,26 @@ var testDeployWithTemplatedName = &latest.HelmDeploy{
 	},
 }
 
+var testDeploySkipBuildDependencies = &latest.HelmDeploy{
+	Releases: []latest.HelmRelease{
+		{
+			Name:                  "skaffold-helm",
+			ChartPath:             "stable/chartmuseum",
+			SkipBuildDependencies: true,
+		},
+	},
+}
+
+var testDeployRemoteChart = &latest.HelmDeploy{
+	Releases: []latest.HelmRelease{
+		{
+			Name:                  "skaffold-helm-remote",
+			ChartPath:             "stable/chartmuseum",
+			SkipBuildDependencies: false,
+		},
+	},
+}
+
 var testNamespace = "testNamespace"
 
 var validDeployYaml = `
@@ -268,6 +288,22 @@ func TestHelmDeploy(t *testing.T) {
 			builds:      testBuilds,
 			shouldErr:   true,
 		},
+		{
+			description: "deploy success remote chart with skipBuildDependencies",
+			cmd:         &MockHelm{t: t},
+			deployer:    NewHelmDeployer(testDeploySkipBuildDependencies, testKubeContext, testNamespace, ""),
+			builds:      testBuilds,
+		},
+		{
+			description: "deploy error remote chart without skipBuildDependencies",
+			cmd: &MockHelm{
+				t:         t,
+				depResult: fmt.Errorf("unexpected error"),
+			},
+			deployer:  NewHelmDeployer(testDeployRemoteChart, testKubeContext, testNamespace, ""),
+			builds:    testBuilds,
+			shouldErr: true,
+		},
 		{
 			description: "get failure should install not upgrade",
 			cmd: &MockHelm{

pkg/skaffold/schema/latest/config.go

@@ -187,19 +187,20 @@ type KustomizeDeploy struct {
 }
 
 type HelmRelease struct {
-	Name              string                 `yaml:"name,omitempty"`
-	ChartPath         string                 `yaml:"chartPath,omitempty"`
-	ValuesFiles       []string               `yaml:"valuesFiles,omitempty"`
-	Values            map[string]string      `yaml:"values,omitempty,omitempty"`
-	Namespace         string                 `yaml:"namespace,omitempty"`
-	Version           string                 `yaml:"version,omitempty"`
-	SetValues         map[string]string      `yaml:"setValues,omitempty"`
-	SetValueTemplates map[string]string      `yaml:"setValueTemplates,omitempty"`
-	Wait              bool                   `yaml:"wait,omitempty"`
-	RecreatePods      bool                   `yaml:"recreatePods,omitempty"`
-	Overrides         map[string]interface{} `yaml:"overrides,omitempty"`
-	Packaged          *HelmPackaged          `yaml:"packaged,omitempty"`
-	ImageStrategy     HelmImageStrategy      `yaml:"imageStrategy,omitempty"`
+	Name                  string                 `yaml:"name,omitempty"`
+	ChartPath             string                 `yaml:"chartPath,omitempty"`
+	ValuesFiles           []string               `yaml:"valuesFiles,omitempty"`
+	Values                map[string]string      `yaml:"values,omitempty,omitempty"`
+	Namespace             string                 `yaml:"namespace,omitempty"`
+	Version               string                 `yaml:"version,omitempty"`
+	SetValues             map[string]string      `yaml:"setValues,omitempty"`
+	SetValueTemplates     map[string]string      `yaml:"setValueTemplates,omitempty"`
+	Wait                  bool                   `yaml:"wait,omitempty"`
+	RecreatePods          bool                   `yaml:"recreatePods,omitempty"`
+	SkipBuildDependencies bool                   `yaml:"skipBuildDependencies,omitempty"`
+	Overrides             map[string]interface{} `yaml:"overrides,omitempty"`
+	Packaged              *HelmPackaged          `yaml:"packaged,omitempty"`
+	ImageStrategy         HelmImageStrategy      `yaml:"imageStrategy,omitempty"`
 }
 
 // HelmPackaged represents parameters for packaging helm chart.