Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#296 Support remote helm chart repositories #1254

Merged
merged 6 commits into from
Jan 30, 2019
Merged

#296 Support remote helm chart repositories #1254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4db4dd1
adding support for remote helm repo
eraac Nov 8, 2018
567f6ea
Merge branch 'master' of github.com:Eraac/skaffold
eraac Nov 8, 2018
eea0099
move bool
eraac Nov 8, 2018
1e2ff3f
adding unit tests for skipBuildDependencies
eraac Nov 27, 2018
73b8fd6
fixing unit test
eraac Nov 27, 2018
d99508c
Merge branch 'master' of github.com:GoogleContainerTools/skaffold
eraac Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/skaffold/deploy/helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,12 @@ func (h *HelmDeployer) deployRelease(ctx context.Context, out io.Writer, r lates
}
}

// First build dependencies.
logrus.Infof("Building helm dependencies...")
if err := h.helm(ctx, out, "dep", "build", r.ChartPath); err != nil {
return nil, errors.Wrap(err, "building helm dependencies")
if !r.SkipBuildDependencies {
// First build dependencies.
logrus.Infof("Building helm dependencies...")
if err := h.helm(ctx, out, "dep", "build", r.ChartPath); err != nil {
return nil, errors.Wrap(err, "building helm dependencies")
}
}

var args []string
Expand Down
27 changes: 14 additions & 13 deletions pkg/skaffold/schema/latest/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,20 @@ type KustomizeDeploy struct {
}

type HelmRelease struct {
Name string `yaml:"name,omitempty"`
ChartPath string `yaml:"chartPath,omitempty"`
ValuesFiles []string `yaml:"valuesFiles,omitempty"`
Values map[string]string `yaml:"values,omitempty,omitempty"`
Namespace string `yaml:"namespace,omitempty"`
Version string `yaml:"version,omitempty"`
SetValues map[string]string `yaml:"setValues,omitempty"`
SetValueTemplates map[string]string `yaml:"setValueTemplates,omitempty"`
Wait bool `yaml:"wait,omitempty"`
RecreatePods bool `yaml:"recreatePods,omitempty"`
Overrides map[string]interface{} `yaml:"overrides,omitempty"`
Packaged *HelmPackaged `yaml:"packaged,omitempty"`
ImageStrategy HelmImageStrategy `yaml:"imageStrategy,omitempty"`
Name string `yaml:"name,omitempty"`
ChartPath string `yaml:"chartPath,omitempty"`
ValuesFiles []string `yaml:"valuesFiles,omitempty"`
Values map[string]string `yaml:"values,omitempty,omitempty"`
Namespace string `yaml:"namespace,omitempty"`
Version string `yaml:"version,omitempty"`
SetValues map[string]string `yaml:"setValues,omitempty"`
SetValueTemplates map[string]string `yaml:"setValueTemplates,omitempty"`
Wait bool `yaml:"wait,omitempty"`
RecreatePods bool `yaml:"recreatePods,omitempty"`
Overrides map[string]interface{} `yaml:"overrides,omitempty"`
Packaged *HelmPackaged `yaml:"packaged,omitempty"`
ImageStrategy HelmImageStrategy `yaml:"imageStrategy,omitempty"`
SkipBuildDependencies bool `yaml:"skipBuildDependencies,omitempty"`
}

// HelmPackaged represents parameters for packaging helm chart.
Expand Down