Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testing): ensure resource cleanup happens on GAE and Cloud Run tests #1683

Merged
merged 4 commits into from
Mar 31, 2020
Merged

fix(testing): ensure resource cleanup happens on GAE and Cloud Run tests #1683

merged 4 commits into from
Mar 31, 2020

Conversation

grayside
Copy link
Collaborator

Fixes #1682. Follow-up to #1634

Integration with buildcop bot clobbered existing test cleanup process for Cloud Run and App Engine.

@grayside grayside requested a review from fhinkel March 30, 2020 21:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
fhinkel
fhinkel approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!

@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 31, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 72631ea into master Mar 31, 2020
@fhinkel fhinkel deleted the twice-trapped-cleanup branch May 14, 2020 23:07
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Merged
@Matthelonianxl Matthelonianxl mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppEngine and Cloud Run have broken cleanup process
4 participants
@grayside @fhinkel @googlebot @kokoro-team