Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: configure buildcopbot #1634

Merged
merged 2 commits into from
Mar 25, 2020
Merged

chore: configure buildcopbot #1634

merged 2 commits into from
Mar 25, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Mar 25, 2020

Fixes: #1615

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2020
@fhinkel fhinkel requested a review from bcoe March 25, 2020 15:32
@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 25, 2020
@fhinkel fhinkel requested a review from tbpg March 25, 2020 15:32
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 25, 2020
tbpg
tbpg approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with NPM test output formatting, but LGTM.

@gcf-merge-on-green gcf-merge-on-green bot merged commit d3fa0d6 into master Mar 25, 2020
@tbpg tbpg deleted the buildcopbot branch March 25, 2020 15:54
This was referenced Mar 30, 2020
Closed
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 31, 2020
@grayside
fix(testing): ensure resource cleanup happens on GAE and Cloud Run te…
72631ea 
…sts (#1683)

Fixes #1682. Follow-up to #1634 

Integration with buildcop bot clobbered existing test cleanup process for Cloud Run and App Engine.
@dlminvestments dlminvestments mentioned this pull request Jul 10, 2023
Open
@aqualen aqualen mentioned this pull request Jul 11, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing: enable the Build Cop Bot
4 participants
@fhinkel @tbpg @googlebot @kokoro-team