Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppEngine and Cloud Run have broken cleanup process #1682

Closed
grayside opened this issue Mar 30, 2020 · 0 comments · Fixed by #1683
Closed

AppEngine and Cloud Run have broken cleanup process #1682

grayside opened this issue Mar 30, 2020 · 0 comments · Fixed by #1683
Assignees
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.

Comments

@grayside
Copy link
Collaborator

  • .kokoro/build-with-appengine.sh uses a trap to clean up deployed appengine services from tests.
  • .kokogo/build-with-run.sh uses a trap to clean up container images published to gcr.io

However, the more recent work to integrate buildcop bot in #1634 added a second trap to ensure reports are sent to the bot with the same function name.

This will always echo "SECOND CLEANUP PROCESS":

#!/usr/bin/env bash
function cleanup {
  echo "FIRST CLEANUP PROCESS!"
}
trap cleanup EXIT
function cleanup {
  echo "SECOND CLEANUP PROCESS!"
}
trap cleanup EXIT

There's not a lot of clever options on how to have multiple traps, but I'll put together something which will fix up the ongoing problem.

I do not have insight into how many GCP resources may be worth manual deletion and will not scope that research into my PR.

@grayside grayside added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern. labels Mar 30, 2020
@grayside grayside self-assigned this Mar 30, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 31, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 31, 2020
…sts (#1683)

Fixes #1682. Follow-up to #1634 

Integration with buildcop bot clobbered existing test cleanup process for Cloud Run and App Engine.
This was referenced Nov 17, 2020
This was referenced Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
2 participants