-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppEngine and Cloud Run have broken cleanup process #1682
Labels
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
type: cleanup
An internal cleanup or hygiene concern.
Comments
grayside
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
type: cleanup
An internal cleanup or hygiene concern.
labels
Mar 30, 2020
grayside
added a commit
that referenced
this issue
Mar 30, 2020
This was referenced Nov 17, 2020
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
type: cleanup
An internal cleanup or hygiene concern.
.kokoro/build-with-appengine.sh
uses a trap to clean up deployed appengine services from tests..kokogo/build-with-run.sh
uses a trap to clean up container images published to gcr.ioHowever, the more recent work to integrate buildcop bot in #1634 added a second trap to ensure reports are sent to the bot with the same function name.
This will always echo "SECOND CLEANUP PROCESS":
There's not a lot of clever options on how to have multiple traps, but I'll put together something which will fix up the ongoing problem.
I do not have insight into how many GCP resources may be worth manual deletion and will not scope that research into my PR.
The text was updated successfully, but these errors were encountered: