Convert inboundServices to an enum.

[nat-henderson]

This will make the documentation better and more readable.

Release Note Template for Downstream PRs (will be copied)

appengine: converted `google_app_engine_standard_app_version`'s `inbound_services` to an enum array, which enhances docs and provides some client-side validation.

Fixes hashicorp/terraform-provider-google#6904.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137647"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDNSKeys_basic|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeImage|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeInstance_basic|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeRouter|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProject_basic|TestAccRedisInstanceDatasource_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccDataSourceSqlDatabaseInstance_basic|TestAccBinaryAuthorizationAttestorIamBindingGenerated|TestAccBinaryAuthorizationAttestorIamMemberGenerated|TestAccBinaryAuthorizationAttestorIamPolicyGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccCloudRunServiceIamBindingGenerated|TestAccComputeInstanceIamBindingGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccComputeInstanceIamPolicyGenerated|TestAccComputeInstanceIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamPolicyGenerated|TestAccDataCatalogEntryGroupIamBindingGenerated|TestAccDataCatalogEntryGroupIamMemberGenerated|TestAccDataCatalogEntryGroupIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapWebIamPolicyGenerated|TestAccIapWebIamBindingGenerated|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccIapWebIamMemberGenerated|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccIapWebTypeComputeIamMemberGenerated|TestAccIapWebTypeComputeIamBindingGenerated|TestAccPubsubTopicIamBindingGenerated|TestAccIapWebTypeAppEngineIamMemberGenerated|TestAccIapWebTypeComputeIamPolicyGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccSecretManagerSecretIamBindingGenerated|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccRuntimeConfigConfigIamBindingGenerated|TestAccSecretManagerSecretIamMemberGenerated|TestAccRuntimeConfigConfigIamMemberGenerated|TestAccSecretManagerSecretIamPolicyGenerated|TestAccServiceManagementServiceIamPolicyGenerated|TestAccServiceManagementServiceIamBindingGenerated|TestAccServiceManagementServiceIamMemberGenerated|TestAccSourceRepoRepositoryIamBindingGenerated|TestAccSourceRepoRepositoryIamMemberGenerated|TestAccStorageBucketIamBindingGenerated You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137648"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 8 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 8 insertions(+), 6 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137865"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 6 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 6 insertions(+), 4 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137869"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineStandardAppVersion_update|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccEndpointsService_basic|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137872"

[danawillow]

I would have expected that an enum would add a validatefunc to the schema to actually enforce the values. How doable is that / do you agree?

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137874"

[nat-henderson]

I would have expected that an enum would add a validatefunc to the schema to actually enforce the values. How doable is that / do you agree?

Strikes me as doable, let me see if I can make that happen...

[nat-henderson]

Okay, I think that does it.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 20 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 10 files changed, 25 insertions(+), 13 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138094"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_misc|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138095"

[danawillow]

Fingers crossed that we have the right list of enums for all the new properties we're validating!