Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert inboundServices to an enum. #6956

Conversation

modular-magician
Copy link
Collaborator

This will make the documentation better and more readable.

Release Note Template for Downstream PRs (will be copied)

appengine: converted `google_app_engine_standard_app_version`'s `inbound_services` to an enum array, which enhances docs and provides some client-side validation.

Fixes #6904.

Derived from GoogleCloudPlatform/magic-modules#3820

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Signed-off-by: Modular Magician <magic-modules@google.com>
@nat-henderson nat-henderson force-pushed the downstream-pr-e9b56d3e2235548c1ab51f788028579d31012aa4 branch from 35a3856 to b07321f Compare August 7, 2020 20:19
@ghost ghost added the size/xs label Aug 7, 2020
@nat-henderson nat-henderson merged commit fb33c65 into hashicorp:master Aug 7, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for warm up requests in google_app_engine_standard_app_version
3 participants