-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ospatch's windows update classification field to be an array. #3823
Update ospatch's windows update classification field to be an array. #3823
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137777" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break backwards compatibility for users who are using this field for a single classification?
Re: backwards compatibility, this never worked. In fact it actually crashed if you set these values server-side and tried to import it. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 9 files changed, 18 insertions(+), 10 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137820" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137822" |
Looks like |
Oh, interesting, looks like that |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 9 files changed, 21 insertions(+), 15 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137848" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137853" |
Also updates docs to display enum options in lists.
Fixes hashicorp/terraform-provider-google#6909.
Supports #3820, because it allows arrays of enums to display values in docs.
Release Note Template for Downstream PRs (will be copied)