Rationalize and apply consistent project settings #2748
Conversation
|
Funny, the JDT compiler uses the settings and has flagged things as errors, but my Eclipse instance didn't. |
|
The google-java-format insists on |
Allows specifying settings that should only apply to our plugins vs third_party.
briandealwis
force-pushed
the
i109-settings
branch
from
cda1844
to
0d2aa5e
Compare
|
An alternative is to continue using the GPE GoogleStyle formatting settings, which is what we were mostly using, and not use the |
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
============================================
+ Coverage 68.25% 68.29% +0.03%
- Complexity 2515 2516 +1
============================================
Files 347 347
Lines 12211 12211
Branches 1465 1465
============================================
+ Hits 8335 8339 +4
+ Misses 3288 3285 -3
+ Partials 588 587 -1
Continue to review full report at Codecov.
|
eclipse/settings/README.md
Outdated
|
|
||
| - uses the [Google Java Format plugin for Eclipse](google-java-format), | ||
| which requires Eclipse Oxygen (4.7) or later. | ||
| - unnecessary declared exceptions on methods are _errors_ |
There was a problem hiding this comment.
runtime too or just checked?
There was a problem hiding this comment.
Checked exceptions only.
eclipse/settings/README.md
Outdated
| The settings require installing the [Google Java Format plugin for | ||
| Eclipse][google-java-format]. Installing the format plugin requires | ||
| downloading the [latest release][google-java-format-release] (named | ||
| `google-java-format-eclipse-plugin_XXXX.jar`)and placing the jar |
| Updating and applying the settings files is a two-step process based | ||
| around the [`eclipse-settings-maven-plugin`][esmp] Maven plugin. | ||
|
|
||
| [esmp]: https://github.com/BSI-Business-Systems-Integration-AG/eclipse-settings-maven-plugin |
There was a problem hiding this comment.
I prefer direct inline links but up to you.
There was a problem hiding this comment.
Me too, but the text was becoming hard to read :-/
|
Can this be merged now? |
|
If we decide to use the |
|
Changed the configuration to ignore non-externalized strings / missing |
|
Eclipse bug 215466 requests tolerating spaces in |
This reverts commit 4218f5a.
This reverts commit 4218f5a.
This PR creates and applies a canonical set of project settings and preferences for JDT, PDE, and m2e.
The PR uses the
eclipse-settings-maven-pluginto apply a set of settings files as packaged up in a Mavenjarartifact. The settings artifact project is found ineclipse/settings/. This settings artifact could be published as a canonical set of settings files (e.g., to Maven Centralcom.google:java-settings-eclipse), though I've included instructions for how to apply changes locally.The settings are based on the GoogleStyle settings from GPE with a few tweaks (described in the
eclipse/settings/README.md). One notable change: it requires us to install the Google Java Format plugin (details inREADME.md).I changed the repo structure to make
/plugins,/featuresand/third_partyto be separate module projects that pull in their child project. This simplifies the main/pom.xmland also allows configuring different settings for those children (i.e., to not configureeclipse-settings-maven-pluginonthird_party).The nice thing about this approach is that it simplifies configuring new projects — just invoke the
eclipse-settingsplugin.This is part of #109