Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message #2789

Merged
merged 3 commits into from
Feb 13, 2018
Merged

fix message #2789

merged 3 commits into from
Feb 13, 2018

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 12, 2018

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the message as it seemed a bit odd to have an Installing… message when it might not actually install. But I'm not sure Locating was a real improvement.

@codecov
Copy link

codecov bot commented Feb 13, 2018

Codecov Report

Merging #2789 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2789   +/-   ##
========================================
  Coverage      68.3%   68.3%           
  Complexity     2527    2527           
========================================
  Files           347     347           
  Lines         12253   12253           
  Branches       1471    1471           
========================================
  Hits           8369    8369           
  Misses         3295    3295           
  Partials        589     589
Impacted Files Coverage Δ Complexity Δ
...tools/eclipse/sdk/internal/CloudSdkInstallJob.java 59.57% <100%> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc80aa...a397774. Read the comment docs.

@elharo elharo merged commit 93603c0 into master Feb 13, 2018
@elharo elharo deleted the i2787 branch February 13, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locating Google Cloud SDK --> Installing Google Cloud SDK
3 participants