Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply and Finish #2766

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Apply and Finish #2766

merged 1 commit into from
Jan 31, 2018

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 31, 2018

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #2766 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2766      +/-   ##
============================================
- Coverage      68.3%   68.28%   -0.03%     
+ Complexity     2485     2482       -3     
============================================
  Files           343      343              
  Lines         12122    12122              
  Branches       1459     1459              
============================================
- Hits           8280     8277       -3     
- Misses         3258     3260       +2     
- Partials        584      585       +1
Impacted Files Coverage Δ Complexity Δ
.../tools/eclipse/test/util/project/ProjectUtils.java 67.61% <0%> (-1.71%) 36% <0%> (-1%)
...e/cloud/tools/eclipse/util/jobs/FuturisticJob.java 79.26% <0%> (-1.22%) 24% <0%> (-1%)
...calAppEngineServerLaunchConfigurationDelegate.java 64.28% <0%> (-0.33%) 38% <0%> (ø)
...ow/ui/preferences/RunOptionsDefaultsComponent.java 77.09% <0%> (+0.72%) 40% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeac33f...5abae1a. Read the comment docs.

@briandealwis
Copy link
Member

LGTM. "Apply and Finish" started in Oxygen, but I'm sure anybody on Neon or Mars will be able to figure it out.

@elharo
Copy link
Contributor Author

elharo commented Jan 31, 2018

Once #2748 goes in Oxygen will be required.

@elharo elharo merged commit 1be15a2 into master Jan 31, 2018
@elharo elharo deleted the elharo-patch-1 branch January 31, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants