Closes #1636 allows Visualize_Metric() to run on just results
#1833
Conversation
| strGroupLevel = lMetric$GroupLevel | ||
| ) | ||
| if(!is.null(dfGroups)) { | ||
| lCharts$metricTable <- Report_MetricTable( |
There was a problem hiding this comment.
@lauramaxwell do you know if Report_MetricTable() is meant to be one of the visualizations that can be rendered with just results? If so, I think I need to make some modifications there
There was a problem hiding this comment.
Ideally, although we should always have participant counts. Still if it's not too much effort this is a good candidate to optionalize group metadata.
R/Report_MetricTable.R
Outdated
| strGroupLevel = c("Site", "Country", "Study"), | ||
| strGroupDetailsParams = NULL, | ||
| vFlags = c(-2, -1, 1, 2) | ||
| ) { | ||
| if(!is.null(dfGroups)) { |
There was a problem hiding this comment.
@samussiah was this what you had in mind? Or was it even allow add_Groups_metadata() to run regardless with NULL values? If the latter, that looks non-trivial, especially the widen_dfGroups() utility function
There was a problem hiding this comment.
This is exactly what I had in mind!
Merge remote-tracking branch 'origin/dev' into fix-1636 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
There was a problem hiding this comment.
Almost there @zdz2101 - Report_MetricTable looks great, but if dfBounds or dfMetrics aren't passed into Visualize_Metric the function bombs where it filters on strMetricID. btw I added a little logic to the individual widgets to more robustly handle the data type of lMetric, so make sure you pull the latest commit.
R/Report_MetricTable.R
Outdated
| strGroupLevel = c("Site", "Country", "Study"), | ||
| strGroupDetailsParams = NULL, | ||
| vFlags = c(-2, -1, 1, 2) | ||
| ) { | ||
| if(!is.null(dfGroups)) { |
There was a problem hiding this comment.
This is exactly what I had in mind!
Overview
Widget_Barchart(),Widget_Scatterplot(),Widget_TimeSeries()should be able to run on just resultsNULLandif(is.null())to allowVisualize_Metric()to run on just the results as wellTest Notes/Sample Code