Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Make parameters optional in Visualize_Metric() #1636

Closed
jwildfire opened this issue Jul 10, 2024 · 0 comments · Fixed by #1833
Closed

Feature: Make parameters optional in Visualize_Metric() #1636

jwildfire opened this issue Jul 10, 2024 · 0 comments · Fixed by #1833
Assignees
@samussiah @zdz2101
Labels
enhancement New feature or request reporting improvements Reporting functionality
Milestone
v2.1.0

Comments

@jwildfire
Copy link
Contributor

jwildfire commented Jul 10, 2024 •
edited by lauramaxwell
Loading

Feature Details

Visualizations should be able to run with just dfResults. All other parameters and data frames should be optional.

Example Code

Possible Implementation

Additional Comments
@jonthegeek jonthegeek mentioned this issue Jul 11, 2024
Open
@samussiah samussiah self-assigned this Jul 11, 2024
@lauramaxwell lauramaxwell added this to the v2.1.0 milestone Jul 31, 2024
@lauramaxwell lauramaxwell added enhancement New feature or request reporting improvements Reporting functionality labels Sep 4, 2024
@zdz2101 zdz2101 linked a pull request Sep 11, 2024 that will close this issue
Closes #1636 allows Visualize_Metric() to run on just results #1833
Merged
samussiah added a commit that referenced this issue Sep 23, 2024
@samussiah
Merge pull request #1833 from Gilead-BioStats/fix-1636
612dd52 
Closes #1636 allows `Visualize_Metric()` to run on just results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samussiah samussiah

@zdz2101 zdz2101

Labels
enhancement New feature or request reporting improvements Reporting functionality
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Closes #1636 allows Visualize_Metric() to run on just results Gilead-BioStats/gsm
4 participants
@jwildfire @samussiah @lauramaxwell @zdz2101