-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1636 allows Visualize_Metric()
to run on just results
#1833
Merged
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0a63105
use results as metrics, set abbreviation to metricid
zdz2101 f91e4ec
runs except `Report_MetricTable()`
zdz2101 d77a3ee
can Report_MetricTable be renderd without group
zdz2101 a9e9164
undo initial accident
zdz2101 3338861
undo unnecessary tabs
zdz2101 4d8f6b4
that's probably the best way to write it?
zdz2101 1e1163d
need to add unit tests
zdz2101 01f4f93
get tests up
zdz2101 f93f655
run devtools doc
zdz2101 fe8e37e
merge issues
zdz2101 740cab1
account for new stopifnot()
zdz2101 4c1c514
explicitly handle `lMetric` data type on the widget side
samussiah b399e99
probably going to want to check cyclomatic complexity one day
zdz2101 64b48b7
resolve conflict
zdz2101 8c939b1
Merge branch 'dev' into fix-1636
zdz2101 d86b0fb
accomodate for latest updates
zdz2101 9959854
needa run devtools::document
zdz2101 a002d39
Merge branch 'dev' into fix-1636
zdz2101 382f0f5
did I mess up doing the merge
zdz2101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lauramaxwell do you know if
Report_MetricTable()
is meant to be one of the visualizations that can be rendered with just results? If so, I think I need to make some modifications thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, although we should always have participant counts. Still if it's not too much effort this is a good candidate to optionalize group metadata.