-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/2.4.1 - Cloud for commands, ping command, more api #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: onebeastchris <github@onechris.mozmail.com>
* Init: Add /geyser ping command * Block just console execution, not everything but console senders * Use RTT as that seems to vary less wildly compared to getPing() * Cleanup, use lang strings * Add ping() method to GeyserConnection in api * Update to cloud changes
To whoever merges this: remember to not squash |
is #4205 going to be in 2.4.1 or in a later api update? |
Likely a later one; given that it adds a config value it likely makes more sense to wait until we move to configurate as that will update existing configs. |
Once we merge this, GeyserMC/GeyserWiki#217 and GeyserMC/GeyserDiscordBot#299 should also be |
* Update DeviceOs to latest protocol * Revert enum name change and add deprecation annotations
) * let extensions specify geyser api version instead of base api version * fix spacing, @link formatting, properly check for compat * Proper warning, update to API changes to also check patch version * Bump base-api version * adapt to new base api changes * Actually bump to 2.4.1 * Update api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java * Address reviews * Address reviews * Update to latest base api changes; proper extension *human* version checking * no need to apply a plugin, that's the default --------- Co-authored-by: Konicai <71294714+Konicai@users.noreply.github.com>
Konicai
approved these changes
Jul 31, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
The issue/feature request relates to the Geyser API
PR: Feature
When a PR implements a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes to be released in version 2.4.1 of the Geyser API. Alongside them, the Geyser version will follow a new versioning scheme to properly reflect changes in the API, as well as indicate that a new Minecraft version is supported. More details on that soon!
API Changes included so far:
/geyser ping
command to Geyser, and exposes a player's ping in the apiOther PRs included:
api
version in their extension.yml, however existing extensions will continue to work.