Fix: Extensions should specify geyser api version instead of base api version #3880

onebeastchris · 2023-06-16T00:11:47Z

Relies on GeyserMC/api#2

Changes:

added geyserApiVersion() to Geyser API, which returns a ApiVersion class with a built in version compatibility check
Extensions are checked against Geyser API version now to prevent crashes when trying to load extensions using newer api than is provided - to account for the old way, we check if the version is 1.0.0.

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java

core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java

Addressed

…ion-api-check

Konicai · 2023-06-19T22:41:13Z

Bumping the base api version seems to have fixed building.

Konicai

Project lead needs to take a look at this

Tim203

Besides these comments I'd remove the major,minor,patch fields of GeyserExtensionDescription and use ApiVersion there as well

core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java

# Conflicts: # api/src/main/java/org/geysermc/geyser/api/GeyserApi.java # core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java # gradle/libs.versions.toml

…escription.java

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java

api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java

api/src/main/java-templates/org.geysermc.geyser.api.util/BuildData.java

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java

api/build.gradle.kts

…xtension-api-check

…hecking

onebeastchris · 2024-07-23T18:34:25Z

~~Merge once GeyserMC/api#6 is merged - not merging now as the api/2.4.1 branch wont build if i do~~ API publishing works now; merging

) * let extensions specify geyser api version instead of base api version * fix spacing, @link formatting, properly check for compat * Proper warning, update to API changes to also check patch version * Bump base-api version * adapt to new base api changes * Actually bump to 2.4.1 * Update api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java * Address reviews * Address reviews * Update to latest base api changes; proper extension *human* version checking * no need to apply a plugin, that's the default --------- Co-authored-by: Konicai <71294714+Konicai@users.noreply.github.com>

let extensions specify geyser api version instead of base api version

69bae4f

Konicai previously requested changes Jun 16, 2023

View reviewed changes

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java Outdated Show resolved Hide resolved

core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java Outdated Show resolved Hide resolved

onebeastchris added 2 commits June 16, 2023 02:21

fix spacing, @link formatting, properly check for compat

123ae7d

Merge branch 'master' into extension-api-check

1994c6c

onebeastchris mentioned this pull request Jun 16, 2023

documentation changes: use Geyser API instead of Base API GeyserMC/GeyserExampleExtension#1

Merged

Konicai added the Extensions label Jun 16, 2023

onebeastchris and others added 6 commits June 17, 2023 04:02

Merge remote-tracking branch 'upstream/master' into extension-api-check

c233e7a

Proper warning, update to API changes to also check patch version

18e3c3b

Merge branch 'master' into extension-api-check

c4bd589

Merge remote-tracking branch 'origin/extension-api-check' into extens…

8ec4e8f

…ion-api-check

Merge branch 'master' into extension-api-check

04ecadc

Bump base-api version

7cf06ad

Merge branch 'master' into extension-api-check

11b6ce6

Konicai approved these changes Jun 22, 2023

View reviewed changes

Tim203 requested changes Jun 27, 2023

View reviewed changes

core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java Outdated Show resolved Hide resolved

core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java Outdated Show resolved Hide resolved

onebeastchris added the PR: On hold When a PR is on hold like if it requires a dependency to be updated first label Jul 1, 2023

This comment was marked as outdated.

Sign in to view

Konicai mentioned this pull request Jul 10, 2024

Add ApiVersion class to get & check for api compatibility GeyserMC/api#2

Merged

onebeastchris added 4 commits July 10, 2024 21:01

Merge remote-tracking branch 'upstream/master' into extension-api-check

507819d

# Conflicts: # api/src/main/java/org/geysermc/geyser/api/GeyserApi.java # core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java # gradle/libs.versions.toml

adapt to new base api changes

4e68ca0

Actually bump to 2.4.1

434ee13

Update api/src/main/java/org/geysermc/geyser/api/extension/ExtensionD…

19c065d

…escription.java

onebeastchris added API The issue/feature request relates to the Geyser API and removed PR: On hold When a PR is on hold like if it requires a dependency to be updated first labels Jul 10, 2024

onebeastchris changed the base branch from master to api/2.4.1 July 12, 2024 09:17

rtm516 requested changes Jul 12, 2024

View reviewed changes

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java Outdated Show resolved Hide resolved

Konicai requested changes Jul 13, 2024

View reviewed changes

api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java Outdated Show resolved Hide resolved

api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java Outdated Show resolved Hide resolved

Address reviews

c6301b3

onebeastchris mentioned this pull request Jul 14, 2024

api/2.4.1 - Cloud for commands, ping command, more api #4862

Merged

2 tasks

onebeastchris changed the title ~~let extensions specify geyser api version instead of base api version~~ Fix: Extensions should specify geyser api version instead of base api version Jul 14, 2024

Redned235 approved these changes Jul 14, 2024

View reviewed changes

Konicai reviewed Jul 15, 2024

View reviewed changes

api/src/main/java-templates/org.geysermc.geyser.api.util/BuildData.java Outdated Show resolved Hide resolved

api/src/main/java/org/geysermc/geyser/api/GeyserApi.java Outdated Show resolved Hide resolved

api/build.gradle.kts Outdated Show resolved Hide resolved

onebeastchris added 2 commits July 15, 2024 17:21

Merge remote-tracking branch 'refs/remotes/upstream/api/2.4.1' into e…

cbcfb85

…xtension-api-check

Address reviews

74bd0bb

rtm516 approved these changes Jul 16, 2024

View reviewed changes

Update to latest base api changes; proper extension *human* version c…

0d91e59

…hecking

no need to apply a plugin, that's the default

093ef4b

Tim203 approved these changes Jul 31, 2024

View reviewed changes

onebeastchris merged commit 0bc960a into GeyserMC:api/2.4.1 Jul 31, 2024
2 checks passed

onebeastchris deleted the extension-api-check branch July 31, 2024 22:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Extensions should specify geyser api version instead of base api version #3880

Fix: Extensions should specify geyser api version instead of base api version #3880

onebeastchris commented Jun 16, 2023 •

edited

Loading

Konicai commented Jun 19, 2023

Konicai left a comment

Tim203 left a comment

This comment was marked as outdated.

onebeastchris commented Jul 23, 2024 •

edited

Loading

Fix: Extensions should specify geyser api version instead of base api version #3880

Fix: Extensions should specify geyser api version instead of base api version #3880

Conversation

onebeastchris commented Jun 16, 2023 • edited Loading

Konicai commented Jun 19, 2023

Konicai left a comment

Choose a reason for hiding this comment

Tim203 left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

onebeastchris commented Jul 23, 2024 • edited Loading

onebeastchris commented Jun 16, 2023 •

edited

Loading

onebeastchris commented Jul 23, 2024 •

edited

Loading