-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeviceOs to latest protocol #4553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this will likely need a new Floodgate build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mark them as deprecated instead I'd add it in a comment saying that those platforms are no longer in use.
Deprecated would indicate to me that they will be removed in the future, but I don't think they'd do that because it'd shift the enum values.
They removed Hololens from the docs but left the gap in the enum values so I think deprecated is good, for this. They also marked the others as deprecated. If they add more they could replace the old values. |
* Update DeviceOs to latest protocol * Revert enum name change and add deprecation annotations
Updated to follow the newly published protocol specification. Will probably need a floodgate update aswell.
https://github.com/CloudburstMC/protocol-docs/blob/master/enums/BuildPlatform.md
We likely want to merge GeyserMC/api#4 first